From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 6F0491F8C6 for ; Tue, 27 Jul 2021 17:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229593AbhG0RLv (ORCPT ); Tue, 27 Jul 2021 13:11:51 -0400 Received: from cloud.peff.net ([104.130.231.41]:58796 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhG0RLv (ORCPT ); Tue, 27 Jul 2021 13:11:51 -0400 Received: (qmail 30926 invoked by uid 109); 27 Jul 2021 17:11:51 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 27 Jul 2021 17:11:51 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 651 invoked by uid 111); 27 Jul 2021 17:11:51 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 27 Jul 2021 13:11:51 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 27 Jul 2021 13:11:50 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com, jonathantanmy@google.com Subject: Re: [PATCH v2 02/24] pack-bitmap-write.c: gracefully fail to write non-closed bitmaps Message-ID: References: <3e637d9ec83435540ad32b8325b0dce87f61bae0.1624314293.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jul 26, 2021 at 02:48:19PM -0400, Taylor Blau wrote: > On Fri, Jul 23, 2021 at 03:37:52AM -0400, Jeff King wrote: > > I thought about suggesting that it be called "err" or "ret" or > > something. And then we do not have to care that fill_bitmap_commit() > > only returns an error in the non-closed state. We are simply propagating > > its error-return back up the stack. > > Hmm. For whatever the inconvience costs us, I do like that the variable > can be named specifically like "open" or "closed" as opposed to the more > generic "err" or "ret". > > So I'll probably keep it is unless you feel strongly (which I suspect > you do not). I don't. -Peff