From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH v2] multi-pack-index: fix potential segfault without sub-command
Date: Fri, 23 Jul 2021 03:34:27 -0400 [thread overview]
Message-ID: <YPpxA1XWw65pRr0P@coredump.intra.peff.net> (raw)
In-Reply-To: <12804130427fd71e88ce10aed283c1f9cdd330ef.1626886330.git.me@ttaylorr.com>
On Wed, Jul 21, 2021 at 12:52:37PM -0400, Taylor Blau wrote:
> I didn't realize that we are veering away from test_i18ngrep in new
> tests, so here's a version of this trivial patch with grep instead.
This looks fine to me, but it looks like Junio may have already merged
the original into 'next' via 995cb54b5b (Merge branch 'tb/reverse-midx'
into next, 2021-07-20).
So we'd have to update it on top. I think we can just leave it be,
though. There's nothing incorrect about using test_i18ngrep for now, and
there are a ton of existing instances to handle if we choose to do a
bulk cleanup. One more isn't a big deal.
-Peff
prev parent reply other threads:[~2021-07-23 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 17:18 [PATCH] multi-pack-index: fix potential segfault without sub-command Taylor Blau
2021-07-21 8:10 ` Jeff King
2021-07-21 16:52 ` [PATCH v2] " Taylor Blau
2021-07-23 7:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPpxA1XWw65pRr0P@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).