From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7FF111F5AE for ; Wed, 21 Jul 2021 12:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234587AbhGULcC (ORCPT ); Wed, 21 Jul 2021 07:32:02 -0400 Received: from cloud.peff.net ([104.130.231.41]:53222 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232239AbhGULcB (ORCPT ); Wed, 21 Jul 2021 07:32:01 -0400 Received: (qmail 2476 invoked by uid 109); 21 Jul 2021 12:12:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 21 Jul 2021 12:12:18 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 4141 invoked by uid 111); 21 Jul 2021 12:12:37 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 21 Jul 2021 08:12:37 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 21 Jul 2021 08:12:37 -0400 From: Jeff King To: Taylor Blau Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com, jonathantanmy@google.com Subject: Re: [PATCH v2 00/24] multi-pack reachability bitmaps Message-ID: References: <87lf6yxqeh.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jul 15, 2021 at 10:36:53AM -0400, Taylor Blau wrote: > I know that reviewing this is on Peff's list of things to do, but there > are competing priorities (and we have all-company meetings this week, so > I would not be surprised to see a lack of movement until at least next > week). I made it through a very careful read of all of the actual code changes, through patch 14. After that, it looks like it's all tests, but my brain is now effectively fried. I had some comments, but nothing earth-shattering. I'll pick up on 15-24 later, though I think between my comments and Ævar's there's some light changes to be made. So don't hesitate to post a new version in the meantime, which can save us a round-trip. -Peff