From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 980881F8C6 for ; Sat, 17 Jul 2021 02:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbhGQChY (ORCPT ); Fri, 16 Jul 2021 22:37:24 -0400 Received: from cloud.peff.net ([104.130.231.41]:52664 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbhGQChX (ORCPT ); Fri, 16 Jul 2021 22:37:23 -0400 Received: (qmail 22700 invoked by uid 109); 17 Jul 2021 02:34:28 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 17 Jul 2021 02:34:28 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16561 invoked by uid 111); 17 Jul 2021 02:34:28 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 16 Jul 2021 22:34:28 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 16 Jul 2021 22:34:26 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Han-Wen Nienhuys , Michael Haggerty Subject: Re: [PATCH v2 00/11] fix "git reflog expire" race & get rid of EISDIR in refs API Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jul 16, 2021 at 04:12:56PM +0200, Ævar Arnfjörð Bjarmason wrote: > builtin/reflog.c | 17 +++--- > reflog-walk.c | 3 +- > refs.c | 5 +- > refs.h | 4 +- > refs/debug.c | 10 ++-- > refs/files-backend.c | 122 ++++++++++-------------------------------- > refs/packed-backend.c | 5 ++ > 7 files changed, 54 insertions(+), 112 deletions(-) The diffstat certainly looks nice. :) I left a few comments on specific patches, mostly just little things. The ones I didn't comment on looked good to me. Overall, it seems like a very nice cleanup. Thanks for putting it together. -Peff