From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2FA3B1F8C6 for ; Sat, 17 Jul 2021 02:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235303AbhGQCHo (ORCPT ); Fri, 16 Jul 2021 22:07:44 -0400 Received: from cloud.peff.net ([104.130.231.41]:52566 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230176AbhGQCHn (ORCPT ); Fri, 16 Jul 2021 22:07:43 -0400 Received: (qmail 22570 invoked by uid 109); 17 Jul 2021 02:04:48 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 17 Jul 2021 02:04:48 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16375 invoked by uid 111); 17 Jul 2021 02:04:48 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 16 Jul 2021 22:04:48 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 16 Jul 2021 22:04:47 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Han-Wen Nienhuys , Michael Haggerty Subject: Re: [PATCH v2 06/11] refs API: pass the "lock OID" to reflog "prepare" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jul 16, 2021 at 04:13:02PM +0200, Ævar Arnfjörð Bjarmason wrote: > diff --git a/builtin/reflog.c b/builtin/reflog.c > index 09541d1c804..9f9e6bceb03 100644 > --- a/builtin/reflog.c > +++ b/builtin/reflog.c > @@ -351,7 +351,7 @@ static int is_head(const char *refname) > } > > static void reflog_expiry_prepare(const char *refname, > - const struct object_id *oid, > + struct object_id *locked_oid, > void *cb_data) > { > struct expire_reflog_policy_cb *cb = cb_data; > @@ -361,7 +361,7 @@ static void reflog_expiry_prepare(const char *refname, > cb->unreachable_expire_kind = UE_HEAD; > } else { > cb->tip_commit = lookup_commit_reference_gently(the_repository, > - oid, 1); > + locked_oid, 1); > if (!cb->tip_commit) > cb->unreachable_expire_kind = UE_ALWAYS; > else This drops "const" from the parameter (also below). I guess this is part of the preparation for making these functions do the locking. I'll read on... -Peff