From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F15791F8C6 for ; Fri, 16 Jul 2021 18:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbhGPSsw (ORCPT ); Fri, 16 Jul 2021 14:48:52 -0400 Received: from cloud.peff.net ([104.130.231.41]:52174 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhGPSsw (ORCPT ); Fri, 16 Jul 2021 14:48:52 -0400 Received: (qmail 21555 invoked by uid 109); 16 Jul 2021 18:45:57 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 16 Jul 2021 18:45:57 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11772 invoked by uid 111); 16 Jul 2021 18:45:57 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 16 Jul 2021 14:45:57 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 16 Jul 2021 14:45:56 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Andrzej Hunt , =?utf-8?B?TMOpbmHDr2M=?= Huard , Derrick Stolee , Felipe Contreras , SZEDER =?utf-8?B?R8OhYm9y?= , =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Eric Sunshine Subject: Re: [PATCH v2 1/4] tests: add a test mode for SANITIZE=leak, run it in CI Message-ID: References: <877dhqxqbt.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jul 16, 2021 at 02:09:22PM -0400, Jeff King wrote: > > Anything that's a lot more granular than that is doing to suck, > > e.g. exposing teh GIT_TEST_SKIP and --run features. of specific test > > numbers, now you need to count your tests if you add one in the middle > > of one of those, and more likely you won't test under the mode and just > > see it in CI. > > I think you can do the same level of skipping with GIT_TEST_SKIP, > though. My argument was just that adding a new mechanism does not make > sense when we already have one. I.e., running: > > GIT_SKIP_TESTS=' > t[123456789]* > t0[^0]* > t00[^016]* > t000[469] > t001[2459] > t006[0248] > ' make SANITIZE=leak test > > works already to do the same thing. The only thing we might want is a > nicer syntax (e.g., to allow positive and negative patterns, or to read > from a file). But that would benefit all users of GIT_SKIP_TESTS, not > just people interested in leaks. I cheated a little here; an unrelated bug does cause a failure in t0000 with this pattern. I've just sent: https://lore.kernel.org/git/YPHTY5G9JaQFKlX5@coredump.intra.peff.net/ to fix it. -Peff