From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 12AA11F8C6 for ; Mon, 26 Jul 2021 17:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231639AbhGZRNN (ORCPT ); Mon, 26 Jul 2021 13:13:13 -0400 Received: from cloud.peff.net ([104.130.231.41]:57630 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbhGZRNM (ORCPT ); Mon, 26 Jul 2021 13:13:12 -0400 Received: (qmail 24968 invoked by uid 109); 26 Jul 2021 17:53:40 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 26 Jul 2021 17:53:40 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22967 invoked by uid 111); 26 Jul 2021 17:53:41 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 26 Jul 2021 13:53:40 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 26 Jul 2021 13:53:39 -0400 From: Jeff King To: Johannes Schindelin via GitGitGadget Cc: Junio C Hamano , git@vger.kernel.org, Ramsay Jones , =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Philippe Blain , Johannes Schindelin Subject: [PATCH] ci: run "apt-get update" before "apt-get install" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Jul 14, 2021 at 11:50:33AM +0000, Johannes Schindelin via GitGitGadget wrote: > + - name: Install other dependencies > + run: | > + sudo apt-get install -q -y libssl-dev libcurl4-openssl-dev libexpat-dev gettext zlib1g-dev My CI runs based on 'next' started failing today. I think we'd want this on top (of js/ci-make-sparse): -- >8 -- Subject: [PATCH] ci: run "apt-get update" before "apt-get install" The "sparse" workflow runs "apt-get install" to pick up a few necessary packages. But it needs to run "apt-get update" first, or it risks trying to download an old package version that no longer exists. And in fact this happens now, with output like: 2021-07-26T17:40:51.2551880Z E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/c/curl/libcurl4-openssl-dev_7.68.0-1ubuntu2.5_amd64.deb 404 Not Found [IP: 52.147.219.192 80] 2021-07-26T17:40:51.2554304Z E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? Our other ci jobs don't suffer from this; they rely on scripts in ci/, and ci/install-dependencies does the appropriate "apt-get update". Signed-off-by: Jeff King --- I guess this package setup could also be moved into ci/install-dependencies.sh, but I don't think it really buys anything (the "apt-get update" line would not even be shared, because the outermost layer is a big switch statement on the jobname). OTOH, it looks like other one-off jobs are in there (e.g., StaticAnalysis). Anyway, this is the minimal fixup. .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1b5c039207..01878884ae 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -368,6 +368,7 @@ jobs: run: sudo dpkg -i sparse-20.04/sparse_*.deb - name: Install other dependencies run: | + sudo apt-get update -q && sudo apt-get install -q -y libssl-dev libcurl4-openssl-dev libexpat-dev gettext zlib1g-dev - uses: actions/checkout@v2 - run: make sparse -- 2.32.0.805.g1fa0022869