From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2021, #03; Tue, 13)
Date: Wed, 14 Jul 2021 16:11:47 -0400 [thread overview]
Message-ID: <YO9FAwre6cj958D/@nand.local> (raw)
In-Reply-To: <xmqqmtqpzosf.fsf@gitster.g>
On Tue, Jul 13, 2021 at 06:07:12PM -0700, Junio C Hamano wrote:
> * tb/midx-use-checksum (2021-06-28) 4 commits
> (merged to 'next' on 2021-07-08 at bbaac9c721)
> + midx: report checksum mismatches during 'verify'
> + midx: don't reuse corrupt MIDXs when writing
> + commit-graph: rewrite to use checksum_valid()
> + csum-file: introduce checksum_valid()
>
> When rebuilding the multi-pack index file reusing an existing one,
> we used to blindly trust the existing file and ended up carrying
> corrupted data into the updated file, which has been corrected.
>
> Will merge to 'master'.
Thanks.
I had a moment of panic over my week off that the new code wasn't using
the right hash for non-SHA-1 repositories. But we check that the hash
version the file was written with matches 'the_hash_algo' at runtime,
and we use 'the_hash_algo->rawsz' to determine the end of the contents,
so we're all good here.
> * tb/multi-pack-bitmaps (2021-06-28) 24 commits
> [...]
>
> The reachability bitmap file used to be generated only for a single
> pack, but now we've learned to generate bitmaps for history that
> span across multiple packfiles.
>
> Comments?
I would definitely appreciate some more comments, but I have only
sporadically been keeping up-to-date with this series. Ævar sent some
suggestions which I've been replying to today as I catch back up, but
they appear mostly cosmetic (at least, the ones that I've read so far).
I think at this point I'd want a deep review from somebody familiar with
bitmaps before re-rolling. Peff and I have both looked over the series
exhaustively within GitHub, but the clean version submitted here should
definitely be checked before merging.
I'm not in a big hurry to merge this, but there are some other good
topics that are built on top (and it makes working on other bitmap
related things kind of a pain since there are two choices for what to
base it on).
Thanks,
Taylor
next prev parent reply other threads:[~2021-07-14 20:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 1:07 What's cooking in git.git (Jul 2021, #03; Tue, 13) Junio C Hamano
2021-07-14 2:16 ` Eric Sunshine
2021-07-14 16:30 ` Junio C Hamano
2021-07-14 22:39 ` Eric Sunshine
2021-07-14 22:44 ` Junio C Hamano
2021-07-14 8:42 ` Han-Wen Nienhuys
2021-07-14 11:53 ` Ævar Arnfjörð Bjarmason
2021-07-14 11:54 ` Ævar Arnfjörð Bjarmason
2021-07-14 17:28 ` Junio C Hamano
2021-07-14 13:11 ` Derrick Stolee
2021-07-14 14:32 ` Ævar Arnfjörð Bjarmason
2021-07-15 16:25 ` [PATCH] CodingGuidelines: recommend gender-neutral description Junio C Hamano
2021-07-15 16:35 ` Eric Sunshine
2021-07-15 16:47 ` Taylor Blau
2021-07-15 18:02 ` Junio C Hamano
2021-07-16 21:25 ` Felipe Contreras
2021-07-15 17:27 ` Derrick Stolee
2021-07-16 15:11 ` Johannes Schindelin
2021-07-16 21:22 ` Felipe Contreras
2021-07-16 18:41 ` [PATCH v2] " Junio C Hamano
2021-07-16 19:05 ` Derrick Stolee
2021-07-16 19:11 ` Ævar Arnfjörð Bjarmason
2021-07-16 19:50 ` Junio C Hamano
2021-07-16 21:14 ` Felipe Contreras
2021-08-12 8:35 ` [PATCH] " Bagas Sanjaya
2021-07-14 20:11 ` Taylor Blau [this message]
2021-07-19 7:35 ` What's cooking in git.git (Jul 2021, #03; Tue, 13) Patrick Steinhardt
2021-07-19 7:53 ` Felipe Contreras
2021-07-19 8:35 ` Jeff King
2021-07-19 10:42 ` Felipe Contreras
2021-07-19 10:56 ` Patrick Steinhardt
2021-07-19 11:25 ` Felipe Contreras
2021-07-19 8:33 ` Jeff King
2021-07-19 10:41 ` Patrick Steinhardt
2021-07-19 10:52 ` Jeff King
2021-07-19 18:40 ` Junio C Hamano
2021-07-19 19:57 ` Felipe Contreras
2021-07-20 6:31 ` Patrick Steinhardt
2021-07-20 7:21 ` Felipe Contreras
2021-07-20 6:32 ` [PATCH] t0000: fix test if run with TEST_OUTPUT_DIRECTORY Patrick Steinhardt
2021-07-20 7:11 ` Jeff King
2021-07-20 16:21 ` Junio C Hamano
2021-07-20 7:24 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO9FAwre6cj958D/@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).