From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F16511FC9A for ; Thu, 15 Jul 2021 05:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238265AbhGOFTS (ORCPT ); Thu, 15 Jul 2021 01:19:18 -0400 Received: from cloud.peff.net ([104.130.231.41]:50418 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238195AbhGOFTR (ORCPT ); Thu, 15 Jul 2021 01:19:17 -0400 Received: (qmail 6410 invoked by uid 109); 15 Jul 2021 05:16:25 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 15 Jul 2021 05:16:25 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31728 invoked by uid 111); 15 Jul 2021 05:16:25 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 15 Jul 2021 01:16:25 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 15 Jul 2021 01:16:23 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Han-Wen Nienhuys , Michael Haggerty Subject: Re: [PATCH] refs file backend: remove dead "errno == EISDIR" code Message-ID: References: <871r801yp6.fsf@evledraar.gmail.com> <875yxczbd6.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875yxczbd6.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jul 15, 2021 at 02:02:40AM +0200, Ævar Arnfjörð Bjarmason wrote: > > Maybe that is splitting hairs, but I definitely try to err on the side > > of caution and over-analysis when touching tricky code (and the > > ref-backend code is in my experience one of the trickiest spots for > > corner cases, races, etc). > > I'd entirely forgotten about this, but I had a patch to remove that > "oid" call entirely, as it's really an unrelated bug/undesired behavior > > You also looked at it at the time & Michael Haggerty reviewed it: > https://lore.kernel.org/git/20190315155959.12390-9-avarab@gmail.com/ > > The state of that patch was that I needed to get to some minor issues > with it (commit message rewording, cleaning up some related callers), > but the fundamental approach seemed good. > > I then split it off from the v4 of that series to get the non-tricky > changes in: > https://lore.kernel.org/git/20190328161434.19200-1-avarab@gmail.com/ > > I then just never got to picking it up again, I'll probably re-roll it & > make it a part of this series, then we can remove this whole OID != NULL > case and will be sure nothing fishy's going on. Yeah, that sounds like a good path forward. I do think the patch under discussion here is probably the right thing to do. But it becomes all the more obvious if lock_ref_oid_basic() ends up dropping that parameter entirely. -Peff