From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7731C1F8C6 for ; Wed, 30 Jun 2021 17:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232416AbhF3RJG (ORCPT ); Wed, 30 Jun 2021 13:09:06 -0400 Received: from cloud.peff.net ([104.130.231.41]:37514 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232335AbhF3RJD (ORCPT ); Wed, 30 Jun 2021 13:09:03 -0400 Received: (qmail 24353 invoked by uid 109); 30 Jun 2021 17:06:33 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 30 Jun 2021 17:06:33 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 8903 invoked by uid 111); 30 Jun 2021 17:06:33 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 30 Jun 2021 13:06:33 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 30 Jun 2021 13:06:32 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Junio C Hamano , Ulrich Windl , Johannes Schindelin , git@vger.kernel.org Subject: Re: Antw: [EXT] Re: git add --interactive patch improvement for split hunks Message-ID: References: <60D45FE4020000A100041FCE@gwsmtp.uni-regensburg.de> <60D9A01C020000A100042099@gwsmtp.uni-regensburg.de> <87eecmgrnx.fsf@evledraar.gmail.com> <874kdfg32w.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <874kdfg32w.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Jun 30, 2021 at 10:27:16AM +0200, Ævar Arnfjörð Bjarmason wrote: > > I'm not sure. I think the topic would have graduated if either you had > > just applied the squash and merged it down, or if the original author > > had checked back in over the intervening year to say "hey, what happened > > to my patch" (either by reading "what's cooking" or manually). > > > > I suspect drive-by contributors might not realize they need to do the > > latter in some cases, but I wouldn't have counted 2014-era Ævar in that > > boat. So I dunno. > > Or maybe the moral of the story that it's a net addition of complexity > to git-add--interactive.perl. If I didn't care enough to remember or > notice the issue again maybe it wasn't all that important to begin with. > > Likewise when it got ejected nobody else seemed to notice/care enough to > say "hey I liked that feature" & to pick it up. Yeah, that's probably a fair interpretation, too. :) > I'd entirely forgotten I wrote that. Now that I'm reminded of it I don't > care enough myself to rebase it, test it again, and especially not to > figure out if/how it's going to interact with the new C implementation / > add and adjust a test for the two. > > But maybe someone else will, it would be neat if someone has more of an > itch from the lack of that feature & wants to pick it up. I can probably save you a little time/mental energy here: the C version already does what your patch was trying to do. Once we switch to it as the default, your patch would be obsolete anyway. :) -Peff