From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id EFF421F8C6 for ; Wed, 30 Jun 2021 02:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232373AbhF3C0E (ORCPT ); Tue, 29 Jun 2021 22:26:04 -0400 Received: from cloud.peff.net ([104.130.231.41]:36984 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232299AbhF3C0E (ORCPT ); Tue, 29 Jun 2021 22:26:04 -0400 Received: (qmail 22246 invoked by uid 109); 30 Jun 2021 02:23:36 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 30 Jun 2021 02:23:36 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1112 invoked by uid 111); 30 Jun 2021 02:23:37 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 29 Jun 2021 22:23:37 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 29 Jun 2021 22:23:35 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Junio C Hamano , Taylor Blau , git@vger.kernel.org, Felipe Contreras Subject: Re: [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag Message-ID: References: <8735t93h0u.fsf@evledraar.gmail.com> <87r1gs1hfx.fsf@evledraar.gmail.com> <871r8r1hwe.fsf@evledraar.gmail.com> <87fsx6xn0b.fsf@evledraar.gmail.com> <875yxxgkav.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875yxxgkav.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jun 29, 2021 at 09:39:26AM +0200, Ævar Arnfjörð Bjarmason wrote: > > I do not see a point in complicating the build procedure to avoid > > using it. > > I'd really understand your and Jeff's concerns if I was proposing some > really complex workaround, but it's just extending & making consistent > the "mv" dance we already use for 1/2 our rules already. Just to clarify my position: I'm not all that upset about adding more uses of "mv", as I agree it's not a lot of code (and in general I like making things atomic). Mostly I was trying to understand your use case, and whether we could be encouraging a more robust workflow there. And that's what I was prodding at in the last email: what's the reason that doing it in a separate workdir doesn't work? I did find your answers compelling that it takes more disk space, and you have to compile everything twice (I do use ccache myself, but I agree that "oh, just install ccache" is not helpful advice in the general case). -Peff