From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C25A91F8C8 for ; Tue, 22 Jun 2021 19:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232415AbhFVTaZ (ORCPT ); Tue, 22 Jun 2021 15:30:25 -0400 Received: from cloud.peff.net ([104.130.231.41]:36328 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbhFVTaZ (ORCPT ); Tue, 22 Jun 2021 15:30:25 -0400 Received: (qmail 6659 invoked by uid 109); 22 Jun 2021 19:28:07 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 22 Jun 2021 19:28:07 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29706 invoked by uid 111); 22 Jun 2021 19:28:07 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 22 Jun 2021 15:28:07 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 22 Jun 2021 15:28:06 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Denton Liu , Felipe Contreras , Kristof Provost Subject: Re: [PATCH 3/3] Makefile: don't use "FORCE" for tags targets Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jun 22, 2021 at 04:21:27PM +0200, Ævar Arnfjörð Bjarmason wrote: > Remove the "FORCE" dependency from the "tags", "TAGS" and "cscope.out" > targets, instead make them depend on whether or not the relevant > source files have changed. > > I'm also removing the "-o" option from them, that seems to have been > cargo-culted when they were initially added in f81e7c626f3 (Makefile: > Add TAGS and tags targets, 2006-03-18). It would make sense to use > that option if we had been appending to tag files, it doesn't make any > sense that it was used after we'd just removed the files file being > appended to. You mean "-a" in this second paragraph, right? I think it would help if xargs splits the source file list across multiple invocations of the command. -Peff