From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>,
"Randall S. Becker" <rsbecker@nexbridge.com>,
git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86
Date: Thu, 3 Jun 2021 22:17:02 -0400 [thread overview]
Message-ID: <YLmNHpf+dXdK7OeH@nand.local> (raw)
In-Reply-To: <xmqqk0na2yyc.fsf@gitster.g>
On Fri, Jun 04, 2021 at 10:36:11AM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > This looks as I'd expect. But after seeing Eric's response, we perhaps
> > want to do away with the knob entirely.
>
> Thanks. I was hoping somebody in the thread would tie the loose
> ends, but upon inspection of the output from
>
> $ git grep -e fsync\( maint seen -- \*.[ch]
>
> it turns out that fsync_or_die() is the only place that calls
> fsync(), so perhaps doing it in a way that is quite different from
> what has been discussed may be even a better alternative.
>
> If any new callers care about the return value of fsync(), I'd
> expect that they would be calling this wrapper, and the "best
> effort" callers that do not check the returned value by definition
> do not care if fsync() does not complete due to an interrupt, so I
> am hoping that the current "we only call it from this wrapper" is
> not just "the code currently happens to be this way", but it is
> sensible that the code will stay that way in the future.
That makes total sense to me; I can't imagine a scenario where you
would want to call fsync() over fsync_or_die(). But if you did, then you
probably don't care about whether or not fsync() was interrupted, or can
check the return value yourself.
If it became more common, then I wouldn't mind #undef-ing fsync() and
replacing it with our own hacked up version.
> Obviously I appreciate reviews and possibly tests, but sanity
> checking my observation that fsync() is called only from here is a
> good thing to have.
Your patch looks good to me (and Randall already tested my version with
the additional knob on NonStop and reported it working as expected[1]),
so this has my:
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Thanks,
Taylor
[1]: https://lore.kernel.org/git/009901d758b4$12016d80$36044880$@nexbridge.com/
next prev parent reply other threads:[~2021-06-04 2:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 17:52 [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86 Randall S. Becker
2021-06-02 19:32 ` Taylor Blau
2021-06-02 19:49 ` Jeff King
2021-06-02 20:11 ` Taylor Blau
2021-06-02 20:15 ` Jeff King
2021-06-02 20:36 ` Randall S. Becker
2021-06-04 1:36 ` Junio C Hamano
2021-06-04 2:17 ` Taylor Blau [this message]
2021-06-04 3:55 ` Jeff King
2021-06-04 5:12 ` Junio C Hamano
2021-06-06 19:06 ` Randall S. Becker
2021-06-08 6:40 ` Jeff King
2021-06-05 7:04 ` René Scharfe
2021-06-05 13:15 ` Junio C Hamano
2021-06-02 20:11 ` Eric Wong
2021-06-02 20:14 ` Jeff King
2021-06-02 20:18 ` Taylor Blau
2021-06-02 20:34 ` Randall S. Becker
2021-06-03 19:31 ` Jeff King
2021-06-03 20:07 ` Randall S. Becker
2021-06-03 20:21 ` Bryan Turner
2021-06-03 20:32 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLmNHpf+dXdK7OeH@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).