From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 7985D1F5AE for ; Sun, 30 May 2021 21:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhE3VtJ (ORCPT ); Sun, 30 May 2021 17:49:09 -0400 Received: from cloud.peff.net ([104.130.231.41]:41546 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229955AbhE3VtG (ORCPT ); Sun, 30 May 2021 17:49:06 -0400 Received: (qmail 18973 invoked by uid 109); 30 May 2021 21:47:27 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sun, 30 May 2021 21:47:27 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22190 invoked by uid 111); 30 May 2021 21:47:27 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sun, 30 May 2021 17:47:27 -0400 Authentication-Results: peff.net; auth=none Date: Sun, 30 May 2021 17:47:26 -0400 From: Jeff King To: Bagas Sanjaya Cc: git@vger.kernel.org, dyroneteng@gmail.com, levraiphilippeblain@gmail.com, stolee@gmail.com Subject: Re: [PATCH] clone: caveat note on converting partial clone Message-ID: References: <20210529120730.38472-1-bagasdotme@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210529120730.38472-1-bagasdotme@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, May 29, 2021 at 07:07:31PM +0700, Bagas Sanjaya wrote: > Currently partial clones can't be converted into full clones, because > there is an issue where the remote can't send all missing objects > required. > > Signed-off-by: Bagas Sanjaya > --- > This patch is based on "clone: document partial clone section" by Teng > Long [1]. > > [1]: > https://lore.kernel.org/git/pull.745.v5.git.git.1614695133486.gitgitgadget@gmail.com/ Wouldn't: git -c fetch.negotiationAlgorithm=noop fetch ... work? IMHO that is not ideal, and I would like to see it work even when we provide "have" lines to the server. But if we are going to tell users something in the documentation, pointing them to this technique is probably much more helpful than saying "it can't be done". -Peff