From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
git@vger.kernel.org, "Taylor Blau" <ttaylorr@github.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH v3] t: use pre-defined utf-8 locale for testing svn
Date: Tue, 8 Jun 2021 02:35:30 -0400 [thread overview]
Message-ID: <YL8PsmLaU+MpWv58@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqk0n6wkrr.fsf@gitster.g>
On Mon, Jun 07, 2021 at 10:01:12AM +0900, Junio C Hamano wrote:
> >> I kind of wonder if trying "C.UTF-8" would be a reasonable fallback so
> >> that people don't even have to set this extra Makefile knob. But I'm not
> >> sure if we have a good way of testing if that locale works (if we can't
> >> find the "locale" binary).
> >
> > I also think we should fallback to "C.UTF-8" instead of not testing those
> > tests. However, I don't know if there're any systems that not have "C.UTF-8"
> > locale.
>
> I do share the feeling, but have a hunch that systems lacking
> "locale -a" may be either superset of, or has at least large overlap
> with, those lacking "C.UTF-8", and the new mechanism introduced here
> will cover both of them, so I think it is OK to stop here, at least
> for now.
Yeah, I think it is OK to stop here, too. I'd worry that we'd make life
unnecessarily complicated for people testing on platforms that lack
"locale" and C.UTF-8, for little gain.
The v4 patch looks good to me.
-Peff
next prev parent reply other threads:[~2021-06-08 6:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 11:46 [PATCH] t: use user-specific utf-8 locale for testing Đoàn Trần Công Danh
2021-06-02 19:56 ` Taylor Blau
2021-06-08 10:49 ` Ævar Arnfjörð Bjarmason
2021-06-03 19:27 ` Jeff King
2021-06-04 3:32 ` Bagas Sanjaya
2021-06-04 5:20 ` Đoàn Trần Công Danh
2021-06-06 16:33 ` [PATCH v2] " Đoàn Trần Công Danh
2021-06-06 20:06 ` Torsten Bögershausen
2021-06-07 0:20 ` Junio C Hamano
2021-06-07 0:48 ` [PATCH v3] t: use pre-defined utf-8 locale for testing svn Đoàn Trần Công Danh
2021-06-07 1:01 ` Junio C Hamano
2021-06-07 14:38 ` Torsten Bögershausen
2021-06-07 15:42 ` Đoàn Trần Công Danh
2021-06-08 6:35 ` Jeff King [this message]
2021-06-08 6:45 ` Đoàn Trần Công Danh
2021-06-07 1:08 ` [PATCH v4] t: use user-specified " Đoàn Trần Công Danh
2021-06-08 6:38 ` Jeff King
2021-06-08 6:56 ` [PATCH v5] " Đoàn Trần Công Danh
2021-06-08 7:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL8PsmLaU+MpWv58@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bagasdotme@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
--cc=ttaylorr@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).