mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: "brian m. carlson" <>
Cc: Siavash <>,
Subject: Re: [Bug] git-credential-netrc.perl is not built and is not available in `exec-path`
Date: Sun, 23 May 2021 15:57:03 -0400	[thread overview]
Message-ID: <YKqzj/DZU8m9AaI/> (raw)
In-Reply-To: <YKgzvFHOcUgPjbj/>

On Fri, May 21, 2021 at 10:27:08PM +0000, brian m. carlson wrote:

> > I agree with this, but just following up with a bit of a devil's
> > advocate: why not put osxkeychain into a regular "make install", but
> > make it conditional via a Makefile knob, like we do for other
> > platform-specific features?
> Sure, let's do it.
> For osxkeychain, it's probably pretty simple to always build it, since
> macOS will always have the appropriate libraries if the compiler is
> installed.

Hmm. So I tried just building oxskeychain in our CI via contrib, and it
fails. :(

It looks like it's OK with clang, but not gcc:

Maybe nobody cares about gcc for this use, but I'm inclined to leave it
to somebody who actually runs macOS to poke at further.

> I would be in favor of also building by default on Linux and
> having a Makefile knob to disable that, since the requisite libraries are
> a part of nearly every distribution and doing so will spur distros to
> ship it, which many do not.

I assume you mean contrib/credential/libsecret here. I'd worry that
flipping it on by default is annoying for people who build from source.
I don't have dev libraries for things like libsecret or glib on my
development system[1], and I'd be surprised if most server-oriented
machines have even the non-dev versions.

Which isn't an argument against making it easier to build them from the
main Makefile, but it seems like having them on by default (with a
NO_LIBSECRET) would cause more surprises than the other way around
(USE_LIBSECRET or similar).

I suspect that just opening a bug report against distro packages might
get some traction (especially if it comes with a patch to create the
extra package). I do wonder if packagers are hesitant to reach into
contrib/, not knowing how well maintained the contents are (to be
honest, I am not confident in how well maintained they are, either; it
might be helpful if somebody who routinely used each helper stepped up
to say that they would maintain it).


[1] I was actually surprised I had libsecret installed at all.
    Apparently pinentry-gtk2 links against it, which I have for use with
    gpg. But my system might not be considered typical anyway, as I
    don't use any kind of "desktop environment".

  reply	other threads:[~2021-05-23 19:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  9:51 [Bug] git-credential-netrc.perl is not built and is not available in `exec-path` Siavash
2021-05-20 20:41 ` Jonathan Nieder
2021-05-21 10:26   ` Siavash
2021-05-21  1:55 ` brian m. carlson
2021-05-21 10:04   ` Jeff King
2021-05-21 22:27     ` brian m. carlson
2021-05-23 19:57       ` Jeff King [this message]
2021-05-24  3:01         ` Felipe Contreras
2021-05-24 10:05           ` Renaming "non-contrib" things out of contrib/* (was "Re: [Bug] git-credential-netrc.perl[...]") Ævar Arnfjörð Bjarmason
2021-05-24 17:21             ` Felipe Contreras
2021-05-24 23:18               ` Ævar Arnfjörð Bjarmason
2021-05-25  1:23                 ` Felipe Contreras
2021-05-25  6:51             ` Junio C Hamano
2021-05-25  7:31               ` Bagas Sanjaya
2021-05-25  9:05                 ` Felipe Contreras
2021-05-25 10:35               ` Felipe Contreras
2021-05-21 10:06 ` [Bug] git-credential-netrc.perl is not built and is not available in `exec-path` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKqzj/DZU8m9AaI/ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).