git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Phillip Wood" <phillip.wood123@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v5] help: colorize man pages
Date: Sat, 22 May 2021 05:56:55 -0400	[thread overview]
Message-ID: <YKjVZ28fxqGq7Baq@coredump.intra.peff.net> (raw)
In-Reply-To: <20210522011718.541986-1-felipe.contreras@gmail.com>

On Fri, May 21, 2021 at 08:17:18PM -0500, Felipe Contreras wrote:

> +	/* Add red to bold, blue to underline, and magenta to standout */
> +	/* No visual information is lost */
> +	setenv("LESS", "Dd+r$Du+b$Ds+m", 0);

Unlike the LESS_TERMCAP_* strategy, this completely breaks "git help"
on my system:

  $ ./git help git
  There is no -D option ("less --help" for help)

  $ man less | grep -A1 '^ *-D'
         -Dxcolor or --color=xcolor
                [MS-DOS only] Sets the color of the text displayed.  x is a single

This is less 551-2 on Debian unstable.

-Peff

  reply	other threads:[~2021-05-22  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22  1:17 [PATCH v5] help: colorize man pages Felipe Contreras
2021-05-22  9:56 ` Jeff King [this message]
2021-05-22 21:15   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKjVZ28fxqGq7Baq@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).