From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A79301F5AE for ; Sat, 22 May 2021 09:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbhEVJ4f (ORCPT ); Sat, 22 May 2021 05:56:35 -0400 Received: from cloud.peff.net ([104.130.231.41]:34320 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbhEVJ4e (ORCPT ); Sat, 22 May 2021 05:56:34 -0400 Received: (qmail 9898 invoked by uid 109); 22 May 2021 09:55:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 22 May 2021 09:55:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 17697 invoked by uid 111); 22 May 2021 09:55:10 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 22 May 2021 05:55:10 -0400 Authentication-Results: peff.net; auth=none Date: Sat, 22 May 2021 05:55:07 -0400 From: Jeff King To: Felipe Contreras Cc: Junio C Hamano , Phillip Wood , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Leah Neukirchen , "Randall S. Becker" Subject: Re: [PATCH v4] help: colorize man pages Message-ID: References: <20210520040725.133848-1-felipe.contreras@gmail.com> <842221d6-51c4-e08a-4299-c4efb8bf1dcb@gmail.com> <60a7f57fe3301_5503920831@natae.notmuch> <60a828cebd2f1_77e4f208b2@natae.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <60a828cebd2f1_77e4f208b2@natae.notmuch> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, May 21, 2021 at 04:40:30PM -0500, Felipe Contreras wrote: > Jeff King wrote: > > On Fri, May 21, 2021 at 01:01:35PM -0500, Felipe Contreras wrote: > > > > > > I still don't understand what we gain by making this a Git feature, > > > > > > What do we gain by making `git diff` output color? > > > > Huh? Git is outputting the diff. Who else would output the color? > > Do you think our users know or care which binary has the final > connection to the tty? Yes. If we are telling them that "git help git" is using "man", which we do, then I think they should expect it to behave like "man". Moreover, I think that if they like colorized manpages, they'd probably want them when running "man" themselves. -Peff