mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <>
To: Jeff King <>
Cc: Siavash <>,
Subject: Re: [Bug] git-credential-netrc.perl is not built and is not available in `exec-path`
Date: Fri, 21 May 2021 22:27:08 +0000	[thread overview]
Message-ID: <YKgzvFHOcUgPjbj/> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 2101 bytes --]

On 2021-05-21 at 10:04:53, Jeff King wrote:
> On Fri, May 21, 2021 at 01:55:32AM +0000, brian m. carlson wrote:
> > Things in contrib are not built by default because they don't
> > necessarily work everywhere.  For example, the osxkeychain credential
> > helper won't compile on Linux because the requisite shared libraries
> > are specific to macOS.  You'll need to compile them manually and install
> > them in a suitable location.
> I agree with this, but just following up with a bit of a devil's
> advocate: why not put osxkeychain into a regular "make install", but
> make it conditional via a Makefile knob, like we do for other
> platform-specific features?

Sure, let's do it.

For osxkeychain, it's probably pretty simple to always build it, since
macOS will always have the appropriate libraries if the compiler is
installed.  I would be in favor of also building by default on Linux and
having a Makefile knob to disable that, since the requisite libraries are
a part of nearly every distribution and doing so will spur distros to
ship it, which many do not.

> And yet, my impression is that basically every Git user on macOS is
> using it every day, because both Apple Git and homebrew build it by
> default (and I think at least in the case of Apple Git, it's hard-coded
> into the config). A little scary, but nobody seems to have complained. :)
> I wonder if we could build it and run it through t0303 as part of the
> mac CI process (though I recall at the time that it was really finicky
> for automated testing; it wouldn't even run over an ssh session).
> Likewise, we probably could be building and testing the libsecret ones
> via the Linux CI job (I don't use those either myself, but presumably
> they pass t0303).

Running the tests will be harder.  macOS, I believe, requires an
interactive session to have the keychain unlocked, and on Linux, you
require gnome-keyring or an equivalent daemon running, which practically
means that you need a desktop session.
brian m. carlson (he/him or they/them)
Houston, Texas, US

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2021-05-21 22:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  9:51 [Bug] git-credential-netrc.perl is not built and is not available in `exec-path` Siavash
2021-05-20 20:41 ` Jonathan Nieder
2021-05-21 10:26   ` Siavash
2021-05-21  1:55 ` brian m. carlson
2021-05-21 10:04   ` Jeff King
2021-05-21 22:27     ` brian m. carlson [this message]
2021-05-23 19:57       ` Jeff King
2021-05-24  3:01         ` Felipe Contreras
2021-05-24 10:05           ` Renaming "non-contrib" things out of contrib/* (was "Re: [Bug] git-credential-netrc.perl[...]") Ævar Arnfjörð Bjarmason
2021-05-24 17:21             ` Felipe Contreras
2021-05-24 23:18               ` Ævar Arnfjörð Bjarmason
2021-05-25  1:23                 ` Felipe Contreras
2021-05-25  6:51             ` Junio C Hamano
2021-05-25  7:31               ` Bagas Sanjaya
2021-05-25  9:05                 ` Felipe Contreras
2021-05-25 10:35               ` Felipe Contreras
2021-05-21 10:06 ` [Bug] git-credential-netrc.perl is not built and is not available in `exec-path` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKgzvFHOcUgPjbj/ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).