* [PATCH] help: fix small typo in error message
@ 2021-05-20 7:42 Jean-Noël Avila
2021-05-20 21:36 ` Jonathan Nieder
2021-05-20 22:53 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Jean-Noël Avila @ 2021-05-20 7:42 UTC (permalink / raw)
To: git; +Cc: Jean-Noël Avila
Classic string concatenation while forgetting a space character.
Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
---
list-objects-filter-options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 96a605c8ad..fd8d59f653 100644
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(
} else if (skip_prefix(arg, "object:type=", &v0)) {
int type = type_from_string_gently(v0, strlen(v0), 1);
if (type < 0) {
- strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
+ strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
"not a valid object type"), v0);
return 1;
}
--
2.31.0.rc2.1.gaceb20851f.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] help: fix small typo in error message
2021-05-20 7:42 [PATCH] help: fix small typo in error message Jean-Noël Avila
@ 2021-05-20 21:36 ` Jonathan Nieder
2021-05-20 22:53 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Nieder @ 2021-05-20 21:36 UTC (permalink / raw)
To: Jean-Noël Avila; +Cc: git, Patrick Steinhardt, Junio C Hamano
(cc: pks)
Jean-Noël Avila wrote:
> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
[...]
> - strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> + strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
> "not a valid object type"), v0);
Good catch!
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] help: fix small typo in error message
2021-05-20 7:42 [PATCH] help: fix small typo in error message Jean-Noël Avila
2021-05-20 21:36 ` Jonathan Nieder
@ 2021-05-20 22:53 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2021-05-20 22:53 UTC (permalink / raw)
To: Jean-Noël Avila; +Cc: git
Jean-Noël Avila <jn.avila@free.fr> writes:
> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
> list-objects-filter-options.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks. This is a new message added in this round, so let's
fast-track this fix down.
> diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
> index 96a605c8ad..fd8d59f653 100644
> --- a/list-objects-filter-options.c
> +++ b/list-objects-filter-options.c
> @@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(
> } else if (skip_prefix(arg, "object:type=", &v0)) {
> int type = type_from_string_gently(v0, strlen(v0), 1);
> if (type < 0) {
> - strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> + strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
> "not a valid object type"), v0);
> return 1;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-20 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 7:42 [PATCH] help: fix small typo in error message Jean-Noël Avila
2021-05-20 21:36 ` Jonathan Nieder
2021-05-20 22:53 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).