git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] help: fix small typo in error message
Date: Thu, 20 May 2021 14:36:36 -0700	[thread overview]
Message-ID: <YKbWZMTW2Evux1VR@google.com> (raw)
In-Reply-To: <20210520074214.40903-1-jn.avila@free.fr>

(cc: pks)
Jean-Noël Avila wrote:

> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
[...]
> -			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> +			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
>  					      "not a valid object type"), v0);

Good catch!

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

  reply	other threads:[~2021-05-20 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  7:42 Jean-Noël Avila
2021-05-20 21:36 ` Jonathan Nieder [this message]
2021-05-20 22:53 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKbWZMTW2Evux1VR@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jn.avila@free.fr \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).