From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id D4F841F934 for ; Thu, 20 May 2021 08:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231149AbhETI3C (ORCPT ); Thu, 20 May 2021 04:29:02 -0400 Received: from cloud.peff.net ([104.130.231.41]:60080 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbhETI3A (ORCPT ); Thu, 20 May 2021 04:29:00 -0400 Received: (qmail 26439 invoked by uid 109); 20 May 2021 08:27:39 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 20 May 2021 08:27:39 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 29080 invoked by uid 111); 20 May 2021 08:27:41 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 20 May 2021 04:27:41 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 20 May 2021 04:27:38 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Gregory Anders , =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Eric Sunshine , Eric Wong Subject: Re: [PATCH v2 00/10] send-email: various optimizations to speed up by >2x Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, May 20, 2021 at 10:18:57AM +0200, Ævar Arnfjörð Bjarmason wrote: > A re-roll of [1], the work I based v1 on top of has landed in master, > so this has been rebased on master. > > The changes here are minor, just a typo fix / commit message > clarification, moving "require" closer to where it's used, and finally > a new 10/10 patch to s/cwd/getcwd/g. I like all of this, except for the change in the interface of Git::config_regexp(). You mention that it's new-ish, and probably not in wide use. And I agree that's probably true. But it feels like violating a principle of not breaking APIs, and we should stick to that principle and not bend it for "well, it's not that old an API". I'd find it more compelling if it the existing interface was broken or hard to avoid changing. But couldn't we just add a new function with the extra info (config_regexp_with_values() or something)? -Peff