mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: Taylor Blau <>
Cc: "Junio C Hamano" <>,, "Han-Wen Nienhuys" <>,
	"Avar Arnfjörð Bjarmason" <>,
	"ZheNing Hu" <>
Subject: Re: CI: 'seen' minus a few passes tests, eh, almost
Date: Wed, 26 May 2021 11:53:34 -0400	[thread overview]
Message-ID: <YK5u/qxFJUr9d/> (raw)
In-Reply-To: <YK5dubBcSwm9c4Ta@nand.local>

On Wed, May 26, 2021 at 10:39:53AM -0400, Taylor Blau wrote:

> On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:
> > Just with a hunch, I further excluded tb/multi-pack-bitmaps from
> > 'seen', in addition to these four topics.  It seems to pass the
> > whole test suite on both 32- and 64-bit build combinations.
> >
> >
> >
> > Except that vs-build sometimes fails to download the sdk, that is.
> Thanks for letting me know. I have accumulated a few local changes that
> I wanted to include in a reroll of that topic, but I was waiting on
> other reviewer eyes before sending it.

I think the best thing in a situation like this (where reviewers like me
have been very slow to respond) is to repost it explaining the
situation. That makes it clear what the current state is, and brings it
to the forefront of the list's attention (both reviewers you'd expect to
look at it, but people in general). Doing that too often can be
obnoxious, of course, but after 6-8 weeks saying "hey, this didn't get
attention; can anybody take a look at it?" is perfectly reasonable.

> I should be able to spend some more time pushing that topic forward
> after the release. There are a few other patch series waiting on it from
> GitHub, too.

But yeah, waiting until after the release is good, to keep attention on
regression fixes in the meantime.


  reply	other threads:[~2021-05-26 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 22:25 CI: 'seen' minus a few passes tests, eh, almost Junio C Hamano
2021-05-26  5:32 ` Junio C Hamano
2021-05-26  6:07   ` Junio C Hamano
2021-05-26 14:39   ` Taylor Blau
2021-05-26 15:53     ` Jeff King [this message]
2021-05-26 16:48       ` Taylor Blau
2021-06-02 11:59   ` Johannes Schindelin
2021-05-26 15:02 ` ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK5u/qxFJUr9d/ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).