From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2E5C11F5AE for ; Thu, 27 May 2021 14:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236383AbhE0OeC (ORCPT ); Thu, 27 May 2021 10:34:02 -0400 Received: from cloud.peff.net ([104.130.231.41]:38818 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235925AbhE0OeB (ORCPT ); Thu, 27 May 2021 10:34:01 -0400 Received: (qmail 4858 invoked by uid 109); 27 May 2021 14:32:28 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 27 May 2021 14:32:28 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3329 invoked by uid 111); 27 May 2021 14:32:28 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 27 May 2021 10:32:28 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 27 May 2021 10:32:27 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org, "brian m . carlson" , Martin =?utf-8?B?w4VncmVu?= , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Felipe Contreras Subject: Re: [PATCH v3 0/5] doc: asciidoc cleanups Message-ID: References: <20210521222941.525901-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, May 25, 2021 at 02:51:54AM +0900, Junio C Hamano wrote: > > Documentation/Makefile | 77 ++++++++++++++++-------------------------- > > 1 file changed, 29 insertions(+), 48 deletions(-) > > Is this satisfactory to everybody (I haven't taken a look beyond > comparing the end results)? Yes, all five patches look good to me. The "comments-by" sub-thread looked unproductive to me, so I mostly skipped it. ;) But as the person whose name was in the trailer, I will say that I do not care either way if it is included. It did not seem to add anything to me. Some trailers are good for pointing later readers to folks who may be able to help understand or debug an old commit. Some are good for just giving credit to people who helped. "Comments-by" didn't really seem to do either to me (and I don't feel like I contributed much worthy of credit anyway). -Peff