From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Theodor Negrescu <theodor.negrescu@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: BUG: Git path --config doesn't work with ~ symbol
Date: Wed, 5 May 2021 14:32:35 -0400 [thread overview]
Message-ID: <YJLkw59nxAU6/vVT@coredump.intra.peff.net> (raw)
In-Reply-To: <CAPig+cTX179z5MrTvSmgYGzZdc4xz=2G_ffHsyVOXsKVHrL93w@mail.gmail.com>
On Wed, May 05, 2021 at 02:21:38PM -0400, Eric Sunshine wrote:
> On Wed, May 5, 2021 at 2:14 PM Jeff King <peff@peff.net> wrote:
> > On Wed, May 05, 2021 at 09:06:12PM +0300, Theodor Negrescu wrote:
> > > I ran the command "git config --file ~/git-settings/.gitconfig -l"
> > > (git-settings is a repo where I keep my config, the global one is just
> > > an include)
> >
> > I don't think this is a bug in git-config. It is generally the shell
> > that is responsible for expanding "~" and passing along the result to
> > commands. E.g.:
> >
> > $ strace -e execve git config --file ~/foo --list
> > execve("/home/peff/local/git/current/bin/git", ["git", "config", "--file", "/home/peff/foo", "--list"], 0x7ffc10a88130 /* 55 vars */) = 0
> >
> > I'd guess this might be related to Windows somehow. Are you entering the
> > command in a bash shell, or via some other mechanism?
>
> Is OPT_FILENAME supposed to handle tilde-expansion? I ask because
> git-config is using OPT_STRING for this option, whereas other commands
> use OPT_FILENAME for their `--file` options.
No, I don't think so. The point of OPT_FILENAME() is that it handles the
directory-change from setting up the git directory before we even the
the cmd_*() function.
But that isn't necessary here, because cmd_config() applies the prefix
manually. So this works as expected:
$ git init
$ mkdir subdir
$ git config --file=foo my.dir root
$ git config --file=subdir/foo my.dir sub
$ git config --file=foo --list
my.dir=root
$ cd subdir
$ git config --file=foo --list
my.dir=sub
Possibly the code could be simplified a little by using OPT_FILENAME(),
though.
-Peff
prev parent reply other threads:[~2021-05-05 18:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 18:06 BUG: Git path --config doesn't work with ~ symbol Theodor Negrescu
2021-05-05 18:13 ` Theodor Negrescu
2021-05-05 18:14 ` Jeff King
2021-05-05 18:21 ` Eric Sunshine
2021-05-05 18:30 ` Theodor Negrescu
2021-05-05 18:35 ` Jeff King
2021-05-05 18:59 ` Theodor Negrescu
2021-05-05 19:01 ` Jeff King
2021-05-05 18:32 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJLkw59nxAU6/vVT@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=theodor.negrescu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).