From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 807BC1F5AE for ; Wed, 5 May 2021 13:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233574AbhEEN6N (ORCPT ); Wed, 5 May 2021 09:58:13 -0400 Received: from cloud.peff.net ([104.130.231.41]:45340 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233178AbhEEN6K (ORCPT ); Wed, 5 May 2021 09:58:10 -0400 Received: (qmail 18452 invoked by uid 109); 5 May 2021 13:57:13 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 05 May 2021 13:57:13 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9743 invoked by uid 111); 5 May 2021 13:57:13 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 05 May 2021 09:57:13 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 5 May 2021 09:57:12 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH 0/5] streaming.c: refactor for smaller + easier to understand code Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, May 05, 2021 at 02:33:27PM +0200, Ævar Arnfjörð Bjarmason wrote: > This is a prep series for my yet-to-be-sent re-roll of [1], > aka. ab/fsck-unexpected-type. > > Jeff King had a comment in [2] saying it was odd to have an "oi2" > variable, that was because there was on an "oi" name already defined > via the new-gone open_method_decl(loose) macro. As we'll see we could > do without the initial "oi" and a few other types of indirection in > this interface. > > Junio: Could you eject ab/fsck-unexpected-type while this is being > considered/cooked? I didn't really see how to address Jeff's feedback > about that variable name in a way that wouldn't just make something > like this refactoring part of an even bigger series. I think ejecting > the functional changes & trying to get this in first is the least > worst approach at this point. Eventually I'll submit a re-roll of > ab/fsck-unexpected-type either based on this, or master (if it's > landed already). I think my feedback was really just: if that patch didn't refactor parse_loose_header() to get rid of the "simple" and extended versions, then you wouldn't have to touch streaming.c at all. It could just continue to use the simple version. That said, I don't mind the cleanups here, especially getting rid of the macros. -Peff