From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F22F91F5AE for ; Wed, 5 May 2021 13:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbhEENpH (ORCPT ); Wed, 5 May 2021 09:45:07 -0400 Received: from cloud.peff.net ([104.130.231.41]:45284 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbhEENpH (ORCPT ); Wed, 5 May 2021 09:45:07 -0400 Received: (qmail 18345 invoked by uid 109); 5 May 2021 13:44:10 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 05 May 2021 13:44:10 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 9569 invoked by uid 111); 5 May 2021 13:44:10 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 05 May 2021 09:44:10 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 5 May 2021 09:44:09 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH 3/5] streaming.c: remove {open,close,read}_method_decl() macros Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, May 05, 2021 at 02:33:30PM +0200, Ævar Arnfjörð Bjarmason wrote: > Remove the {open,close,read}_method_decl() macros added in > 46bf043807c (streaming: a new API to read from the object store, > 2011-05-11) in favor of inlining the definition of the arguments of > these functions. > > Since we'll end up using them via the "{open,close,read}_istream_fn" > types we don't gain anything in the way of compiler checking by using > these macros, and as of preceding commits we no longer need to declare > these argument lists twice. So declaring them at a distance just > serves to make the code less readable. Heh. I have a very similar patch pending. In addition to readability, my reasons there are: - you can't find the functions with ctags, etc, when they're hidden behind macros - you can't annotate the function interfaces to avoid -Wunused-parameter warnings. :) So I am very much in favor of this (and patch 1 is nice here, too, because it skips an extra time you'd have to repeat the interface in the forward declaration). -Peff