From: Jeff King <email@example.com> To: "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org> Cc: email@example.com, "SZEDER Gábor" <firstname.lastname@example.org>, "Junio C Hamano" <email@example.com> Subject: Re: [PATCH 1/9] t7415: remove out-dated comment about translation Date: Mon, 3 May 2021 16:29:49 -0400 [thread overview] Message-ID: <YJBdPXkogxeERdi8@coredump.intra.peff.net> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, May 03, 2021 at 11:46:52AM +0200, Ævar Arnfjörð Bjarmason wrote: > > Since GETTEXT_POISON does not exist anymore, there is no point warning > > people about whether we should use test_i18ngrep. This is doubly > > confusing because the comment was describing why it was OK to use grep, > > but it got caught up in the mass conversion of 674ba34038 (fsck: mark > > strings for translation, 2018-11-10). > > > > Note there are other uses of test_i18ngrep in this script which are now > > obsolete; I'll save those for a mass-cleanup. My goal here was just to > > fix the confusing comment in code I'm about to refactor. > > For what it's worth between  and  I'm not sure what to do about > the test_i18ngrep cleanup. I think your patch below is fine, but the > "test_i18ngrep" has mutated into a "grep with debugging", not just > something needed for GETTEXT_POISON. Yes, I can see some value in that. Though if that's what it's going to be, IMHO we should use it consistently and give a better name (test_grep or something). > So that part of your patch right now is making it less friendly for > debugging. I don't care, and think if we want that we'd be better of > scraping the trace ouput for such common cases and/or use "verbose grep > [...]" and teach the "verbose" wrapper about these common cases, but > knowing of that objection + having other outstanding things has been why > I haven't sent s/test_i18ngrep/grep/g patches. I was the one who introduced "verbose" long ago, and I did have dreams that people would do "verbose grep" everywhere. But in the end, we made "-x" a lot nicer to use, and I think that largely obsoletes it. Using "verbose" makes the non-x verbose output slightly nicer, perhaps. But not having to remember to sprinkle "verbose" through the test code (nor read it) seems like a bigger win to me. For the same reason, I'm pretty ambivalent about having test_grep. I suppose one could make a similar argument about "test_path_is_missing", etc, though some of those helpers are also encapsulating technique (e.g., test_dir_is_empty). -Peff
next prev parent reply other threads:[~2021-05-03 20:29 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-01 15:40 [PATCH 0/9] leftover bits from symlinked gitattributes, etc topics Jeff King 2021-05-01 15:41 ` [PATCH 1/9] t7415: remove out-dated comment about translation Jeff King 2021-05-03 9:46 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:29 ` Jeff King [this message] 2021-05-01 15:41 ` [PATCH 2/9] fsck_tree(): fix shadowed variable Jeff King 2021-05-03 11:15 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:13 ` Jeff King 2021-05-04 10:10 ` Ævar Arnfjörð Bjarmason 2021-05-01 15:41 ` [PATCH 3/9] fsck_tree(): wrap some long lines Jeff King 2021-05-03 11:22 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:23 ` Jeff King 2021-05-01 15:42 ` [PATCH 4/9] t7415: rename to expand scope Jeff King 2021-05-01 15:42 ` [PATCH 5/9] t7450: test verify_path() handling of gitmodules Jeff King 2021-05-01 18:55 ` Eric Sunshine 2021-05-01 19:03 ` Eric Sunshine 2021-05-03 19:39 ` Jeff King 2021-05-03 10:12 ` Ævar Arnfjörð Bjarmason 2021-05-03 20:32 ` Jeff King 2021-05-01 15:42 ` [PATCH 6/9] t7450: test .gitmodules symlink matching against obscured names Jeff King 2021-05-01 15:42 ` [PATCH 7/9] t0060: test ntfs/hfs-obscured dotfiles Jeff King 2021-05-01 15:43 ` [PATCH 8/9] fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW Jeff King 2021-05-01 15:43 ` [PATCH 9/9] docs: document symlink restrictions for dot-files Jeff King 2021-05-01 19:16 ` Eric Sunshine 2021-05-03 20:33 ` Jeff King 2021-05-03 5:36 ` [PATCH 0/9] leftover bits from symlinked gitattributes, etc topics Junio C Hamano 2021-05-03 20:42 ` [PATCH v2 " Jeff King 2021-05-03 20:43 ` [PATCH v2 1/9] t7415: remove out-dated comment about translation Jeff King 2021-05-03 20:43 ` [PATCH v2 2/9] fsck_tree(): fix shadowed variable Jeff King 2021-05-03 20:43 ` [PATCH v2 3/9] fsck_tree(): wrap some long lines Jeff King 2021-05-03 20:43 ` [PATCH v2 4/9] t7415: rename to expand scope Jeff King 2021-05-03 20:43 ` [PATCH v2 5/9] t7450: test verify_path() handling of gitmodules Jeff King 2021-05-03 20:43 ` [PATCH v2 6/9] t7450: test .gitmodules symlink matching against obscured names Jeff King 2021-05-03 20:43 ` [PATCH v2 7/9] t0060: test ntfs/hfs-obscured dotfiles Jeff King 2021-05-03 20:43 ` [PATCH v2 8/9] fsck: warn about symlinked dotfiles we'll open with O_NOFOLLOW Jeff King 2021-05-03 20:43 ` [PATCH v2 9/9] docs: document symlink restrictions for dot-files Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJBdPXkogxeERdi8@coredump.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/9] t7415: remove out-dated comment about translation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).