From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 99DAF1F5AE for ; Mon, 3 May 2021 20:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229582AbhECUeA (ORCPT ); Mon, 3 May 2021 16:34:00 -0400 Received: from cloud.peff.net ([104.130.231.41]:43494 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhECUd6 (ORCPT ); Mon, 3 May 2021 16:33:58 -0400 Received: (qmail 7461 invoked by uid 109); 3 May 2021 20:33:04 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 03 May 2021 20:33:04 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7279 invoked by uid 111); 3 May 2021 20:33:05 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 03 May 2021 16:33:05 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 3 May 2021 16:33:03 -0400 From: Jeff King To: Eric Sunshine Cc: Git List Subject: Re: [PATCH 9/9] docs: document symlink restrictions for dot-files Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, May 01, 2021 at 03:16:09PM -0400, Eric Sunshine wrote: > Just a really microscopic nit... feel free to ignore... > > > diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt > > @@ -1247,6 +1247,13 @@ to: > > +NOTES > > +----- > > + > > +Note that Git does not follow symbolic links when accessing a > > +`.gitattributes` file in the working tree. This keeps behavior > > +consistent when the file is accessed from the index or a tree versus > > +from the filesystem. > > We're in the "NOTES" section, so it feels redundant to begin the > sentence with "Note that". Thanks. I think it's a good suggestion. I agree it's pretty minor, but I'm going to re-roll anyway to drop the test_i18ngrep, so I'll reword this, too. -Peff