From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 3E23E1F5AE for ; Mon, 3 May 2021 19:39:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbhECTj5 (ORCPT ); Mon, 3 May 2021 15:39:57 -0400 Received: from cloud.peff.net ([104.130.231.41]:43408 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhECTj4 (ORCPT ); Mon, 3 May 2021 15:39:56 -0400 Received: (qmail 7170 invoked by uid 109); 3 May 2021 19:39:02 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 03 May 2021 19:39:02 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 6823 invoked by uid 111); 3 May 2021 19:39:02 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 03 May 2021 15:39:02 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 3 May 2021 15:39:01 -0400 From: Jeff King To: Eric Sunshine Cc: Git List Subject: Re: [PATCH 5/9] t7450: test verify_path() handling of gitmodules Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, May 01, 2021 at 03:03:56PM -0400, Eric Sunshine wrote: > On Sat, May 1, 2021 at 2:55 PM Eric Sunshine wrote: > > On Sat, May 1, 2021 at 11:42 AM Jeff King wrote: > > > + tree=$(git -C symlink mktree > > > `tree` is an unusually generic name for this now-global variable. One > > can easily imagine it being re-used by some unrelated test arbitrarily > > inserted into this script, thus potentially breaking the following > > tests which depend upon it. I wonder if a name such as `BAD_TREE` > > would be more appropriate. > > I see that all `$tree` references get encapsulated into a shell > function by the next patch, so perhaps the generic name `tree` isn't a > big deal after all. Yeah. I'd like to think it is not that big a deal between even just adjacent tests, because anybody adding tests in the middle of a script would take care not to split related ones. But that may be too optimistic. ;) At any rate, it seems OK to assume the function will all be used together. -Peff