From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Yiyuan guo <yguoaz@gmail.com>
Subject: Re: [PATCH 1/5] t5300: modernize basic tests
Date: Mon, 3 May 2021 10:53:54 -0400 [thread overview]
Message-ID: <YJAOgrZVt2oSGCfw@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqk0og8k09.fsf@gitster.g>
On Mon, May 03, 2021 at 02:27:18PM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > The first set of tests in t5300 goes back to 2005, and doesn't use some
> > of our customary style and tools these days. In preparation for touching
> > them, let's modernize a few things:
> > ...
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > t/t5300-pack-object.sh | 243 ++++++++++++++---------------------------
> > 1 file changed, 85 insertions(+), 158 deletions(-)
>
> Thanks. That was an impressive list of a "few" things ;-) The
> result certainly is much easier to follow.
Sometimes these things get bigger than you expected. :)
-Peff
next prev parent reply other threads:[~2021-05-03 14:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 14:02 [PATCH 0/5] pack-objects: better handling of negative options Jeff King
2021-05-01 14:02 ` [PATCH 1/5] t5300: modernize basic tests Jeff King
2021-05-03 5:27 ` Junio C Hamano
2021-05-03 14:53 ` Jeff King [this message]
2021-05-01 14:03 ` [PATCH 2/5] t5300: check that we produced expected number of deltas Jeff King
2021-05-01 14:03 ` [PATCH 3/5] pack-objects: clamp negative window size to 0 Jeff King
2021-05-03 12:10 ` Derrick Stolee
2021-05-03 14:55 ` Jeff King
2021-05-04 18:47 ` René Scharfe
2021-05-04 21:38 ` Jeff King
2021-05-05 11:53 ` Ævar Arnfjörð Bjarmason
2021-05-05 16:19 ` René Scharfe
2021-05-01 14:04 ` [PATCH 4/5] t5316: check behavior of pack-objects --depth=0 Jeff King
2021-05-01 14:04 ` [PATCH 5/5] pack-objects: clamp negative depth to 0 Jeff King
2021-05-03 12:11 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJAOgrZVt2oSGCfw@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=yguoaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).