From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5B9501F5AE for ; Sat, 15 May 2021 09:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232473AbhEOJkn (ORCPT ); Sat, 15 May 2021 05:40:43 -0400 Received: from cloud.peff.net ([104.130.231.41]:55466 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbhEOJkj (ORCPT ); Sat, 15 May 2021 05:40:39 -0400 Received: (qmail 23446 invoked by uid 109); 15 May 2021 09:39:24 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 15 May 2021 09:39:24 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 8357 invoked by uid 111); 15 May 2021 09:39:26 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 15 May 2021 05:39:26 -0400 Authentication-Results: peff.net; auth=none Date: Sat, 15 May 2021 05:39:24 -0400 From: Jeff King To: Felipe Contreras Cc: git@vger.kernel.org, Martin =?utf-8?B?w4VncmVu?= , "brian m . carlson" , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA Message-ID: References: <20210514121435.504423-1-felipe.contreras@gmail.com> <20210514121435.504423-2-felipe.contreras@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, May 15, 2021 at 05:32:08AM -0400, Jeff King wrote: > On Fri, May 14, 2021 at 07:14:25AM -0500, Felipe Contreras wrote: > > > Without `override` all additions will be ignored by make. > > That's true of all of our Makefile variables. Is there a particular > reason to give this one special treatment? To go into further detail: usually we distinguish variables we use internally from user-facing ones, and include the latter in the former. I see a later patch wants to start passing ASCIIDOC_EXTRA on the command-line, and we'd use two variables for that. -Peff