From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id ED3591F5AE for ; Fri, 23 Apr 2021 10:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241786AbhDWKIN (ORCPT ); Fri, 23 Apr 2021 06:08:13 -0400 Received: from cloud.peff.net ([104.130.231.41]:33212 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbhDWKIM (ORCPT ); Fri, 23 Apr 2021 06:08:12 -0400 Received: (qmail 6218 invoked by uid 109); 23 Apr 2021 10:07:36 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 23 Apr 2021 10:07:36 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 6762 invoked by uid 111); 23 Apr 2021 10:07:38 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 23 Apr 2021 06:07:38 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 23 Apr 2021 06:07:35 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Patrick Steinhardt , git@vger.kernel.org Subject: Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value Message-ID: References: <874kg14490.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <874kg14490.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Apr 20, 2021 at 12:52:43PM +0200, Ævar Arnfjörð Bjarmason wrote: > > Mitigate this inconsistency by accepting both syntaxes and add tests to > > verify both work. > > > > Signed-off-by: Patrick Steinhardt > > This whole series LGTM. Me too. Thanks for finding it (and Patrick for fixing it). > > + } else if (!strcmp(cmd, "--config-env")) { > > + if (*argc < 2) { > > + fprintf(stderr, _("no config key given for --config-env\n" )); > > > I found this use of fprintf() slightly odd, why not error(), but then > went back and read the function and saw that it has N number of > "fprintf(stderr, [...])" already. > > That could probably all be converted to error(), but better to be > consistent for now. Yep. Likewise the weird extra space at the end of the string. -Peff