From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value
Date: Fri, 23 Apr 2021 06:07:35 -0400 [thread overview]
Message-ID: <YIKcZxEDsG7qsE4G@coredump.intra.peff.net> (raw)
In-Reply-To: <874kg14490.fsf@evledraar.gmail.com>
On Tue, Apr 20, 2021 at 12:52:43PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > Mitigate this inconsistency by accepting both syntaxes and add tests to
> > verify both work.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
>
> This whole series LGTM.
Me too. Thanks for finding it (and Patrick for fixing it).
> > + } else if (!strcmp(cmd, "--config-env")) {
> > + if (*argc < 2) {
> > + fprintf(stderr, _("no config key given for --config-env\n" ));
>
>
> I found this use of fprintf() slightly odd, why not error(), but then
> went back and read the function and saw that it has N number of
> "fprintf(stderr, [...])" already.
>
> That could probably all be converted to error(), but better to be
> consistent for now.
Yep. Likewise the weird extra space at the end of the string.
-Peff
next prev parent reply other threads:[~2021-04-23 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 15:56 [PATCH 0/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-19 15:56 ` [PATCH 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt
2021-04-19 15:56 ` [PATCH 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-20 10:52 ` Ævar Arnfjörð Bjarmason
2021-04-23 10:07 ` Jeff King [this message]
2021-04-20 11:24 ` Ævar Arnfjörð Bjarmason
2021-04-29 12:55 ` [PATCH v2 0/2] " Patrick Steinhardt
2021-04-29 12:55 ` [PATCH v2 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt
2021-04-29 12:55 ` [PATCH v2 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-29 20:04 ` [PATCH v2 0/2] " Jeff King
2021-04-30 0:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIKcZxEDsG7qsE4G@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).