From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0B45A1F4B4 for ; Sat, 17 Apr 2021 09:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235879AbhDQJCY (ORCPT ); Sat, 17 Apr 2021 05:02:24 -0400 Received: from cloud.peff.net ([104.130.231.41]:54956 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbhDQJCX (ORCPT ); Sat, 17 Apr 2021 05:02:23 -0400 Received: (qmail 30040 invoked by uid 109); 17 Apr 2021 09:01:57 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 17 Apr 2021 09:01:57 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 2604 invoked by uid 111); 17 Apr 2021 09:01:58 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 17 Apr 2021 05:01:58 -0400 Authentication-Results: peff.net; auth=none Date: Sat, 17 Apr 2021 05:01:56 -0400 From: Jeff King To: Ramsay Jones Cc: Junio C Hamano , Patrick Steinhardt , git@vger.kernel.org, Christian Couder , Taylor Blau , Philip Oakley Subject: Re: [PATCH v4 0/8] rev-list: implement object type filter Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Apr 17, 2021 at 02:17:32AM +0100, Ramsay Jones wrote: > On Fri, Apr 16, 2021 at 04:15:39PM -0700, Junio C Hamano wrote: > > Junio C Hamano writes: > > > > > I think the only remaining issues are the comments on 5/8 on tests, > > > then? Hopefully we can have one more iteration to finalize the > > > topic and merge it down to 'next'? > > > > > > Thanks. > > > > I guess not. I am guessing this topic is responsible for > > > > https://github.com/git/git/runs/2366364023?check_suite_focus=true#step:4:115 > > Yes, I noticed this a few days ago, and tried the obvious fix (ie to > #include "cache.h" at the start of the list-objects-filter-options.h > header file) which does indeed work fine. However, I then thought that > moving the definition of 'enum object_type' (along with the TYPE_BITS > #define) to the 'object.h' header file (and #include "object.h" into > cache.h) would be a better idea... > > Having done that, I wondered how many '#include "cache.h"' could be > replaced by "object.h", and ... well, that was a few days ago and > something came up... I agree that would probably be nice, but let's not hold up the topic. It can include "cache.h" like a bunch of other headers in the meantime. (Too bad we can't just forward-declare the enum like we do for some other types, but it's impossible in C). -Peff