git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2021, #04; Thu, 15)
Date: Thu, 15 Apr 2021 23:04:38 -0400	[thread overview]
Message-ID: <YHj+xvav1I0UGAe0@coredump.intra.peff.net> (raw)
In-Reply-To: <YHj9mUzs+jlgNuVE@coredump.intra.peff.net>

On Thu, Apr 15, 2021 at 10:59:37PM -0400, Jeff King wrote:

> On Thu, Apr 15, 2021 at 05:04:37PM -0700, Junio C Hamano wrote:
> 
> > * ps/config-global-override (2021-04-13) 3 commits
> >   (merged to 'next' on 2021-04-15 at 60a58d74ab)
> >  + config: allow overriding of global and system configuration
> >  + config: unify code paths to get global config paths
> >  + config: rename `git_etc_config()`
> > 
> >  Replace GIT_CONFIG_NOSYSTEM mechanism to decline from reading the
> >  system-wide configuration file with GIT_CONFIG_SYSTEM that lets
> >  users specify from which file to read the system-wide configuration
> >  (setting it to an empty file would essentially be the same as
> >  setting NOSYSTEM), and introduce GIT_CONFIG_GLOBAL to override the
> >  per-user configuration in $HOME/.gitconfig.
> > 
> >  Will merge to 'master'.
> 
> Looks like this fails CI on the Windows VS build. I get:
> 
>   ++ env GIT_CONFIG_GLOBAL=does-not-exist GIT_CONFIG_SYSTEM=/dev/null git config --global --list
>   fatal: unable to access 'nul': Invalid argument
> 
> from t1300.181. I thought we had some magic to make /dev/null work there
> (or maybe this _is_ the magic kicking in, since it is looking for the
> Windows-ish nul, but it is not working for some reason).

Ah, indeed. mingw_open() has:

          if (filename && !strcmp(filename, "/dev/null"))
                wcscpy(wfilename, L"nul");

which is clearly kicking in. But I have no idea why that might not work
here. We may need some assistance from Windows folks (cc'd).

-Peff

  reply	other threads:[~2021-04-16  3:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  0:04 What's cooking in git.git (Apr 2021, #04; Thu, 15) Junio C Hamano
2021-04-16  2:59 ` Jeff King
2021-04-16  3:04   ` Jeff King [this message]
2021-04-16 11:21   ` Johannes Schindelin
2021-04-16 13:33     ` Junio C Hamano
2021-04-17  8:47     ` Jeff King
2021-04-17 13:19 ` Ævar Arnfjörð Bjarmason
2021-04-18 16:55 ` Sergey Organov
2021-04-18 19:09   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHj+xvav1I0UGAe0@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).