From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id DC0EB1F4B4 for ; Tue, 13 Apr 2021 07:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239202AbhDMHps (ORCPT ); Tue, 13 Apr 2021 03:45:48 -0400 Received: from cloud.peff.net ([104.130.231.41]:50868 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238194AbhDMHpn (ORCPT ); Tue, 13 Apr 2021 03:45:43 -0400 Received: (qmail 28723 invoked by uid 109); 13 Apr 2021 07:45:21 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 13 Apr 2021 07:45:21 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23355 invoked by uid 111); 13 Apr 2021 07:45:22 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 13 Apr 2021 03:45:22 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 13 Apr 2021 03:45:21 -0400 From: Jeff King To: Patrick Steinhardt Cc: git@vger.kernel.org, Christian Couder , Taylor Blau , Philip Oakley Subject: Re: [PATCH v4 0/8] rev-list: implement object type filter Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Apr 12, 2021 at 03:37:14PM +0200, Patrick Steinhardt wrote: > this is the fourth version of my patch series which implements a new > `object:type` filter for git-rev-list(1) and git-upload-pack(1) and > extends support for bitmap indices to work with combined filters. > > Changes compared to v3: > > - Small style fix to not pass an empty string and `0`, but instead > simply pass two `NULL` pointers to > `list_objects_filter__filter_object, pointed out by Junio. > > - I've changed patch 7/8 as proposed by Peff: support of combined > filters is now determined directly in `filter_bitmap()`, without > having to mirror all filter types in the new `filter_supported()` > function. > > - Renamed `--filter-provided-revisions` to > `--filter-provided-objects` as proposed by Peff and addressed both > commit message and tests as pointed out by Philip. Thanks. I have no more nits to pick. The only question left for me is the big one of "do we like this with --filter, or should it be some kind of rev-list option", as discussed in: https://lore.kernel.org/git/YHB7R8hVRt+V+i2W@coredump.intra.peff.net/ As I said elsewhere, I'm OK going with this route. I just wanted to call attention to that earlier response in case you had any final thoughts (I'm guessing your final thoughts are "jeez, I already wrote it with --filter, so let's just go with that" which is perfectly reasonable to me. ;) ). -Peff