From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id EF64B1F4B4 for ; Fri, 9 Apr 2021 18:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234538AbhDISLG (ORCPT ); Fri, 9 Apr 2021 14:11:06 -0400 Received: from cloud.peff.net ([104.130.231.41]:46604 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234499AbhDISLF (ORCPT ); Fri, 9 Apr 2021 14:11:05 -0400 Received: (qmail 705 invoked by uid 109); 9 Apr 2021 18:10:51 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 09 Apr 2021 18:10:51 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14728 invoked by uid 111); 9 Apr 2021 18:10:51 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 09 Apr 2021 14:10:51 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 9 Apr 2021 14:10:50 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin , Taylor Blau , Elijah Newren Subject: Re: [PATCH 2/6] object.c: remove "gently" argument to type_from_string_gently() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 09, 2021 at 10:32:50AM +0200, Ævar Arnfjörð Bjarmason wrote: > Get rid of the "gently" argument to type_from_string_gently() to make > it consistent with most other *_gently() functions. It's already a > "gentle" function, it shouldn't need a boolean argument telling it to > be gentle. > > The reason it had a "gentle" parameter was because until the preceding > commit "type_from_string()" was a macro resolving to > "type_from_string_gently()", it's now a function. > > This refactoring of adding a third parameter was done in > fe8e3b71805 (Refactor type_from_string() to allow continuing after > detecting an error, 2014-09-10) in preparation for its use in > fsck.c. > > Simplifying this means we can move the die() into the simpler > type_from_string() function. Yeah, this makes sense (and the change of signature will catch any callers in topics-in-flight). -Peff