From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 01B051F4B4 for ; Fri, 9 Apr 2021 15:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233745AbhDIPzt (ORCPT ); Fri, 9 Apr 2021 11:55:49 -0400 Received: from cloud.peff.net ([104.130.231.41]:46352 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233019AbhDIPzt (ORCPT ); Fri, 9 Apr 2021 11:55:49 -0400 Received: (qmail 31866 invoked by uid 109); 9 Apr 2021 15:55:36 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 09 Apr 2021 15:55:36 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12642 invoked by uid 111); 9 Apr 2021 15:55:35 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 09 Apr 2021 11:55:35 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 9 Apr 2021 11:55:35 -0400 From: Jeff King To: Patrick Steinhardt Cc: git@vger.kernel.org, Christian Couder , Taylor Blau Subject: Re: [PATCH v2 7/8] pack-bitmap: implement combined filter Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 09, 2021 at 01:17:59PM +0200, Patrick Steinhardt wrote: > > Before this patch, I think your test: > > > > > +test_expect_success 'combine filter' ' > > > + git rev-list --objects --filter=blob:limit=1000 --filter=object:type=blob tag >expect && > > > + git rev-list --use-bitmap-index \ > > > + --objects --filter=blob:limit=1000 --filter=object:type=blob tag >actual && > > > + test_bitmap_traversal expect actual > > > +' > > > > would pass anyway, because we'd just skip using bitmaps. Is there a way > > we can tell that the bitmap code actually kicked in? Maybe a perf test > > would make it clear (those aren't always run, but hopefully we'd > > eventually notice a regression there). > > I think that's not actually true. Note that we're using > `test_bitmap_traversal`: Ah, right. I forgot about the hackery in test_bitmap_traversal() to let us tell the difference (even though I was the one who wrote it, I still consider it hackery ;) ). So yes, this is a good test that we are allowing the combine filter. -Peff