From: Patrick Steinhardt <ps@pks.im>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] list-objects-filter-options.h: fix an 'hdr-check' warning
Date: Mon, 19 Apr 2021 12:53:57 +0200 [thread overview]
Message-ID: <YH1hRQKM1mQk99Iy@tanuki> (raw)
In-Reply-To: <fc73f7e7-44ca-773a-7f49-e3bf29dd25bb@ramsayjones.plus.com>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Sat, Apr 17, 2021 at 10:37:09PM +0100, Ramsay Jones wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Patrick,
>
> If you need to re-roll your 'ps/rev-list-object-type-filter' branch,
> could you please squash this into the relevant patch (commit 890c534cea
> ("list-objects: implement object type filter", 2021-04-12)).
>
> Sorry for being a bit tardy with this email - normally I would have sent
> it soon after your branch hit 'seen', but I got distracted. ;-)
>
> Thanks!
>
> ATB,
> Ramsay Jones
Thanks a lot for the fixup, will do!
Patrick
>
> list-objects-filter-options.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/list-objects-filter-options.h b/list-objects-filter-options.h
> index 4d0d0588cc..da5b6737e2 100644
> --- a/list-objects-filter-options.h
> +++ b/list-objects-filter-options.h
> @@ -1,6 +1,7 @@
> #ifndef LIST_OBJECTS_FILTER_OPTIONS_H
> #define LIST_OBJECTS_FILTER_OPTIONS_H
>
> +#include "cache.h"
> #include "parse-options.h"
> #include "string-list.h"
>
> --
> 2.31.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-19 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 21:37 [PATCH] list-objects-filter-options.h: fix an 'hdr-check' warning Ramsay Jones
2021-04-19 10:53 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH1hRQKM1mQk99Iy@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).