From: Jeff King <peff@peff.net>
To: "lilinchao@oschina.cn" <lilinchao@oschina.cn>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: Re: [PATCH 2/2] remote-curl.c: handle v1 when check_smart_http
Date: Mon, 29 Mar 2021 06:40:17 -0400 [thread overview]
Message-ID: <YGGukSxGVnTeXae0@coredump.intra.peff.net> (raw)
In-Reply-To: <68765f14907111eb8e180024e87935e7@oschina.cn>
On Mon, Mar 29, 2021 at 05:30:29PM +0800, lilinchao@oschina.cn wrote:
> >Anyway, that's all just an interesting side note. The client is happy
> >with either form (though it might be nice if we had tests for the "#
> >service" form; I suspect our tests don't cover that because they are all
> >using http-backend).
> >
> >Getting back to the patch at hand, if there is a server saying "version
> >1" without a "service" line, then I think that is a bug in that server.
> >
> If the problem is on the server side, then, is this patch worth continuing?
IMHO, no. I think the response from gitee.com is violating the protocol
spec. It would be nice to fix, but in practice it isn't all that
important because somebody would have to manually set protocol.version=1
to see the problem.
-Peff
prev parent reply other threads:[~2021-03-29 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210324053648.25584-1-lilinchao@oschina.cn>
2021-03-24 5:36 ` [PATCH 2/2] remote-curl.c: handle v1 when check_smart_http lilinchao
2021-03-24 20:28 ` Junio C Hamano
2021-03-24 20:33 ` Junio C Hamano
[not found] ` <388751448ce011ebaaead4ae5278bc1265898@pobox.com>
2021-03-25 4:22 ` lilinchao
2021-03-26 6:24 ` Jeff King
2021-03-26 6:55 ` Jeff King
[not found] ` <e4d6bef08dfb11eb90f0a4badb2c2b1115536@peff.net>
2021-03-29 9:30 ` lilinchao
2021-03-29 10:40 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGGukSxGVnTeXae0@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lilinchao@oschina.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).