From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 2579A1F9FC for ; Sun, 28 Mar 2021 07:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbhC1HW5 (ORCPT ); Sun, 28 Mar 2021 03:22:57 -0400 Received: from cloud.peff.net ([104.130.231.41]:51258 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbhC1HWj (ORCPT ); Sun, 28 Mar 2021 03:22:39 -0400 Received: (qmail 25670 invoked by uid 109); 28 Mar 2021 07:22:39 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sun, 28 Mar 2021 07:22:39 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 24774 invoked by uid 111); 28 Mar 2021 07:22:38 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sun, 28 Mar 2021 03:22:38 -0400 Authentication-Results: peff.net; auth=none Date: Sun, 28 Mar 2021 03:22:38 -0400 From: Jeff King To: "brian m. carlson" Cc: Jeffrey Walton , Git List Subject: Re: Git 2.31.1, Solaris and error: conflicting types for 'inet_ntop' Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Mar 28, 2021 at 01:26:10AM +0000, brian m. carlson wrote: > On 2021-03-28 at 01:04:32, Jeffrey Walton wrote: > > I see what happened... I stopped Autoreconfing so the configure.ac > > changes were not picked up. The original configure is being used. > > > > I think Git is getting itself into that state. > > > > Without the Autoreconf, I was able to sidestep the issue with: > > > > if [[ "${IS_SOLARIS}" -eq 1 ]]; then > > CONFIG_OPTS+=("ac_cv_func_inet_ntop=yes") > > CONFIG_OPTS+=("ac_cv_func_inet_pton=yes") > > fi > > Most developers don't use the autoconf stuff and just use the makefile. > config.mak.uname doesn't have NO_INET_NTOP set for SunOS. > > If the autoconf scripts or config.mak.uname need fixing, which is > possible, a patch would definitely be welcome. This all seemed vaguely familiar, and indeed it came up about a year ago: https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/ Maybe worth resurrecting this patch (at the very least it needed a signoff): https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/ -Peff