From: Jeff King <peff@peff.net>
To: Martin Fick <mfick@codeaurora.org>
Cc: Han-Wen Nienhuys <hanwen@google.com>, git <git@vger.kernel.org>
Subject: Re: Distinguishing FF vs non-FF updates in the reflog?
Date: Thu, 18 Mar 2021 18:54:42 -0400 [thread overview]
Message-ID: <YFPaMj9PVfXlp4bL@coredump.intra.peff.net> (raw)
In-Reply-To: <21556546.pz8f0XPdgJ@mfick-lnx>
On Thu, Mar 18, 2021 at 04:31:24PM -0600, Martin Fick wrote:
> On Thursday, March 18, 2021 9:58:56 AM MDT Han-Wen Nienhuys wrote:
> > The bitmaps are generated by GC, and you can't GC all the time.
>
> I believe that I recently saw an effort to make this incremental, perhaps
> related to the geometric repacking series? If that were the case, you could gc
> much more often cheaply. Perhaps it could be something done on every upload at
> some point the way that reflog effectively does on every update?
That geometric repacking work is leading up to having a bitmap for a
multi-pack-index. Which will make them _cheaper_, but still not
especially cheap (because we've reordered the objects corresponding to
each bit, and also because our writing process still does a lot of
O(nr_commits) work).
In the very long run, I think the way out would be to stop using pack or
midx ordering as the basis of the bitmap, and instead have a stable
object ordering that can be appended to. That would allow true
incremental generation of the bitmaps (leaving old ones in place, and
just adding a new ones to represent new commits). But that's such a big
departure from the status quo that having a midx bitmap seemed like a
more attainable middle ground in the meantime.
-Peff
next prev parent reply other threads:[~2021-03-18 22:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:06 Distinguishing FF vs non-FF updates in the reflog? Han-Wen Nienhuys
2021-03-17 21:21 ` Martin Fick
2021-03-18 8:58 ` Han-Wen Nienhuys
2021-03-18 19:35 ` Jeff King
2021-03-18 22:24 ` Martin Fick
2021-03-22 12:31 ` Han-Wen Nienhuys
2021-03-22 17:45 ` Martin Fick
2021-03-18 22:31 ` Martin Fick
2021-03-18 22:54 ` Jeff King [this message]
2021-03-18 19:47 ` Jeff King
2021-03-22 14:40 ` Han-Wen Nienhuys
2021-03-26 7:43 ` Jeff King
2021-03-22 13:26 ` Ævar Arnfjörð Bjarmason
2021-03-22 14:59 ` Han-Wen Nienhuys
2021-03-22 15:39 ` Ævar Arnfjörð Bjarmason
2021-03-22 15:56 ` Han-Wen Nienhuys
2021-03-22 16:40 ` Ævar Arnfjörð Bjarmason
2021-03-22 17:12 ` Han-Wen Nienhuys
2021-03-22 18:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFPaMj9PVfXlp4bL@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=mfick@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).