From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pete Boere <pete@duel.me>,
git@vger.kernel.org, John Lin <johnlinp@gmail.com>
Subject: Re: Extra blank lines in "git status" output have been reduced
Date: Wed, 17 Mar 2021 16:18:46 -0400 [thread overview]
Message-ID: <YFJkJvJdO5XsrvO/@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqo8fhtvst.fsf@gitster.g>
On Wed, Mar 17, 2021 at 12:38:42PM -0700, Junio C Hamano wrote:
> Pete Boere <pete@duel.me> writes:
>
> > With the release of v2.23 I have noticed from the commit:
> > 7b098429355bb3271f9ffdf73b97f2ef82794fea
> > ...
> > Is there any chance of adding them back? The changed layout has been
> > throwing me off ever since upgrading.
>
> Sorry, but it is way too late to complain, generally after a change
> hits a release, and especially after it got buried under 8 new major
> releases. Unless a change was an unintended side-effect that we did
> not mean to make, in which case we would likely to fix it as a bug.
>
> And the change in question b2f5171e (status: remove the empty line
> after hints, 2019-06-04) quite deliberately targets at removing
> these extra lines [*], so no, I do not think it is reasonable to
> expect reverting that commit that is more than a year old.
>
> You may want to join the list discussion and stop whatever UI change
> you find undesirable before it materializes next time.
If we discover later that some portion of users prefer an older
behavior, it may be reasonable to build on top with a config option to
allow selecting the old or the new. The inputs to "may be reasonable"
there are:
- how big is the code burden to support both behaviors? In this case,
I don't think it's too bad; it's restoring the old newlines with a
conditional
- how many people would actually care enough to set the option? Even
without a lot of code, each option is _some_ burden to carry, both
in the code and in the overall complexity of the interface. I'm less
convinced in this particular case that a lot of people care (given a
single comment after many releases), but perhaps those interested in
the change could produce data (note I said "data", not "argue more
vigorously" ;) ).
It might help justify such an option if it applied in more places.
E.g., an option for "I prefer the look of lots of whitespace in
messages" versus "I prefer a more compact look".
-Peff
next prev parent reply other threads:[~2021-03-17 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 10:22 Extra blank lines in "git status" output have been reduced Pete Boere
2021-03-17 19:38 ` Junio C Hamano
2021-03-17 20:18 ` Jeff King [this message]
2021-03-17 21:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFJkJvJdO5XsrvO/@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnlinp@gmail.com \
--cc=pete@duel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).