From: Jeff King <peff@peff.net>
To: Drew DeVault <sir@cmpwn.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Eli Schwartz <eschwartz@archlinux.org>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: Regarding the depreciation of ssh+git/git+ssh protocols
Date: Tue, 16 Mar 2021 17:28:41 -0400 [thread overview]
Message-ID: <YFEjCU1jgrsPIhvk@coredump.intra.peff.net> (raw)
In-Reply-To: <C9YUBUYH7PWU.3PHDZR2YCUEOX@taiga>
On Tue, Mar 16, 2021 at 10:21:13AM -0400, Drew DeVault wrote:
> > It's difficult enough to handle parsing of SSH specifications and
> > distinguish them uniformly from Windows paths (think of an alias named
> > "c"), so I'd prefer we didn't add additional complexity to handle this
> > case.
>
> There's no additional complexity here: git remotes are URIs, and any
> implementation which parses them as such already deals with this case
> correctly. Any implementation which doesn't may face all kinds of
> problems as a consequence: SSH without a user specified, HTTPS with
> Basic auth in the URI username/password fields (or just the password,
> which is also allowed), and so on. Any sane and correct implementation
> is pulling in a URI parser here, and if not, I don't think it's fair for
> git to constrain itself in order to work around some other project's
> bugs.
Git remotes are most definitely not just URIs. Some valid remotes are:
".", "foo", "/tmp/foo", "c:\foo", "example.com:foo". The parser inside
Git has rules to distinguish these from actual rfc3986-compliant URIs.
Now I don't know much about the parsing code in, say, git-lfs, or how
much of pain it would be to add a new scheme for something that _does_
conform to rfc3986. But it's not necessarily as easy as "you should be
using a compliant URI parser".
-Peff
next prev parent reply other threads:[~2021-03-16 21:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 16:27 Regarding the depreciation of ssh+git/git+ssh protocols Drew DeVault
2021-03-15 17:56 ` Jonathan Nieder
2021-03-15 18:14 ` Drew DeVault
2021-03-15 22:01 ` brian m. carlson
2021-03-16 0:52 ` Drew DeVault
2021-03-16 1:02 ` Jonathan Nieder
2021-03-16 1:05 ` Drew DeVault
2021-03-16 21:23 ` Jeff King
2021-03-17 14:49 ` Drew DeVault
2021-03-18 21:30 ` Junio C Hamano
2021-03-18 21:53 ` Drew DeVault
2021-03-16 4:38 ` Eli Schwartz
2021-03-16 11:54 ` brian m. carlson
2021-03-16 14:21 ` Drew DeVault
2021-03-16 21:28 ` Jeff King [this message]
2021-03-17 14:50 ` Drew DeVault
2021-03-17 0:45 ` Jakub Narębski
2021-03-17 14:53 ` Drew DeVault
2021-03-17 22:06 ` brian m. carlson
2021-03-18 12:53 ` Drew DeVault
2021-03-16 18:03 ` Eli Schwartz
2021-03-17 22:15 ` Jonathan Nieder
2021-03-31 4:23 ` Eli Schwartz
2021-04-07 13:46 ` Mark Lodato
2021-04-07 19:46 ` Junio C Hamano
2021-04-13 8:52 ` Kerry, Richard
2021-03-16 0:54 ` Drew DeVault
-- strict thread matches above, loose matches on Subject: below --
2023-10-13 20:49 David Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFEjCU1jgrsPIhvk@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=eschwartz@archlinux.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).