From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0C4471F9FD for ; Mon, 1 Mar 2021 09:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234280AbhCAJxY (ORCPT ); Mon, 1 Mar 2021 04:53:24 -0500 Received: from cloud.peff.net ([104.130.231.41]:47884 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234374AbhCAJwY (ORCPT ); Mon, 1 Mar 2021 04:52:24 -0500 Received: (qmail 4611 invoked by uid 109); 1 Mar 2021 09:51:41 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 01 Mar 2021 09:51:41 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 21830 invoked by uid 111); 1 Mar 2021 09:51:41 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 01 Mar 2021 04:51:41 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 1 Mar 2021 04:51:40 -0500 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Lars Schneider , git , SZEDER =?utf-8?B?R8OhYm9y?= Subject: Re: [PATCH/RFC] test-lib: make --verbose work under prove Message-ID: References: <20161021104107.vh3bjx6x6pd6izat@sigill.intra.peff.net> <20161021104759.hx6q7u66r3ll7l44@sigill.intra.peff.net> <87tupwj5y5.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87tupwj5y5.fsf@evledraar.gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Feb 28, 2021 at 09:25:06PM +0100, Ævar Arnfjörð Bjarmason wrote: > As explained in 452320f1f5 (test-lib: add --verbose-log option, > 2016-10-21) combining the "--verbose" option with the TAP-parsing > "prove" utility would result in broken tests. > > This is because "prove" expects valid TAP on stdout, and if there's a > stray line starting with "ok", or other invalid TAP syntax it will > error on the test. > > In 452320f1f5 numerous potential methods are discussed for dealing > with this problem, but not the one implemented here, which I think is > a much simpler approach. I guess I don't really have an objection to this method existing, but I don't see the point of it now. The original problem has been solved, and I don't find this any simpler than --verbose-log (on the contrary, I find it much more complicated). So I don't know why I would want to use this instead. -Peff