From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 565A91F9FD for ; Fri, 26 Feb 2021 08:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbhBZIAp (ORCPT ); Fri, 26 Feb 2021 03:00:45 -0500 Received: from cloud.peff.net ([104.130.231.41]:45694 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbhBZIAl (ORCPT ); Fri, 26 Feb 2021 03:00:41 -0500 Received: (qmail 12542 invoked by uid 109); 26 Feb 2021 07:59:53 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 26 Feb 2021 07:59:53 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 17205 invoked by uid 111); 26 Feb 2021 07:59:53 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 26 Feb 2021 02:59:53 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 26 Feb 2021 02:59:53 -0500 From: Jeff King To: Junio C Hamano Cc: Jeff Hostetler via GitGitGadget , git@vger.kernel.org, Jeff Hostetler , SZEDER =?utf-8?B?R8OhYm9y?= , Johannes Schindelin , Jeff Hostetler Subject: Re: [PATCH v4 00/12] Simple IPC Mechanism Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Feb 25, 2021 at 11:39:39AM -0800, Junio C Hamano wrote: > "Jeff Hostetler via GitGitGadget" writes: > > > Here is V4 of my "Simple IPC" series. It addresses Gábor's comment WRT > > shutting down the server to make unit tests more predictable on CI servers. > > (https://lore.kernel.org/git/20210213093052.GJ1015009@szeder.dev) > > > > Jeff > > > > cc: Ævar Arnfjörð Bjarmason avarab@gmail.com cc: Jeff Hostetler > > git@jeffhostetler.com cc: Jeff King peff@peff.net cc: Chris Torek > > chris.torek@gmail.com > > It seems that the discussions around the topic has mostly done > during the v2 review, and has quieted down since then. > > Let's merge it down to 'next'? Sorry, I hadn't gotten around to looking at the latest version. I left another round of comments. Some of them are arguably bikeshedding, but there's at least one I think we'd want to address (the big stack buffer in patch 1). I also haven't carefully looked at the simple-ipc design at all; my focus has just been on the details of socket and pktline code being touched. Since there are no simple-ipc users yet, and since it's internal and would be easy to change later, I'm mostly content for Jeff to proceed as he sees fit and iterate on it as necessary. -Peff