From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5D00B1F9FE for ; Fri, 26 Feb 2021 07:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbhBZH0a (ORCPT ); Fri, 26 Feb 2021 02:26:30 -0500 Received: from cloud.peff.net ([104.130.231.41]:45644 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbhBZH00 (ORCPT ); Fri, 26 Feb 2021 02:26:26 -0500 Received: (qmail 12311 invoked by uid 109); 26 Feb 2021 07:25:38 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 26 Feb 2021 07:25:38 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16932 invoked by uid 111); 26 Feb 2021 07:25:38 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 26 Feb 2021 02:25:38 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 26 Feb 2021 02:25:38 -0500 From: Jeff King To: Jeff Hostetler via GitGitGadget Cc: git@vger.kernel.org, Jeff Hostetler , SZEDER =?utf-8?B?R8OhYm9y?= , Johannes Schindelin , Jeff Hostetler Subject: Re: [PATCH v4 07/12] unix-socket: elimiate static unix_stream_socket() helper function Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Feb 17, 2021 at 09:48:43PM +0000, Jeff Hostetler via GitGitGadget wrote: > From: Jeff Hostetler > > The static helper function `unix_stream_socket()` calls `die()`. This > is not appropriate for all callers. Eliminate the wrapper function > and make the callers propagate the error. Thanks for breaking it up this way. It's (IMHO) much easier to see the motivation and impact of the changes now. There's a small typo in the subject: > Subject: unix-socket: elimiate static unix_stream_socket() helper function -Peff