From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id C5FD61F9FD for ; Tue, 23 Feb 2021 03:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbhBWDke (ORCPT ); Mon, 22 Feb 2021 22:40:34 -0500 Received: from cloud.peff.net ([104.130.231.41]:41116 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230310AbhBWDkd (ORCPT ); Mon, 22 Feb 2021 22:40:33 -0500 Received: (qmail 23011 invoked by uid 109); 23 Feb 2021 03:39:53 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 23 Feb 2021 03:39:53 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23057 invoked by uid 111); 23 Feb 2021 03:39:52 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 22 Feb 2021 22:39:52 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 22 Feb 2021 22:39:52 -0500 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com Subject: Re: [PATCH v4 0/8] repack: support repacking into a geometric sequence Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Feb 22, 2021 at 09:24:59PM -0500, Taylor Blau wrote: > Here's a very lightly modified version on v3 of mine and Peff's series > to add a new 'git repack --geometric' mode. Almost nothing has changed > since last time, with the exception of: > > - Packs listed over standard input to 'git pack-objects --stdin-packs' > are sorted in descending mtime order (and objects are strung > together in pack order as before) so that objects are laid out > roughly newest-to-oldest in the resulting pack. > > - Swapped the order of two paragraphs in patch 5 to make the perf > results clearer. > > - Mention '--unpacked' specifically in the documentation for 'git > repack --geometric'. > > - Typo fixes. Thanks, this all looks great to me. -Peff