From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 76A391FB0F for ; Thu, 4 Mar 2021 00:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241105AbhCDAXH (ORCPT ); Wed, 3 Mar 2021 19:23:07 -0500 Received: from cloud.peff.net ([104.130.231.41]:50646 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbhCCNmr (ORCPT ); Wed, 3 Mar 2021 08:42:47 -0500 Received: (qmail 22013 invoked by uid 109); 3 Mar 2021 13:41:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 03 Mar 2021 13:41:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 26961 invoked by uid 111); 3 Mar 2021 13:41:30 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 03 Mar 2021 08:41:30 -0500 Authentication-Results: peff.net; auth=none Date: Wed, 3 Mar 2021 08:41:30 -0500 From: Jeff King To: Junio C Hamano Cc: Joachim Schmitz , Matt Kraai , "Randall S. Becker" , git@vger.kernel.org, Aleksey Kliger Subject: Re: [PATCH] config.mak.uname: enable OPEN_RETURNS_EINTR for macOS Big Sur Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Mar 01, 2021 at 03:57:35PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I got another off-list report of the problem. I think we probably want > > to do this on top: > > Queued and pushed out. Thanks. I guess we're a bit late to make it into the upcoming release. Certainly we have survived for many years without this particular bugfix, so in that sense it is not urgent. But I do wonder if we will see more reports as more people start using the new macOS release. So it might be good to keep in mind for maint, if we cut a minor release. Or alternatively, we could include _just_ the first patch. That's low risk, since you have to enable to knob yourself, but it gives people an option if they run into the symptom. But even that is probably not that urgent. People can also cherry-pick the patch, after all (and a distributor like homebrew can probably include the patch in their recipe if need be). > I wonder if these hits for SA_RESTART in config.mak.uname would be a > good way to guide us. > > [6c109904 (Port to HP NonStop, 2012-09-19)] > # Not detected (nor checked for) by './configure'. > # We don't have SA_RESTART on NonStop, unfortunalety. > COMPAT_CFLAGS += -DSA_RESTART=0 > > [40036bed (Port to QNX, 2012-12-18)] > ifeq ($(uname_S),QNX) > COMPAT_CFLAGS += -DSA_RESTART=0 I'm inclined to leave them alone until somebody with access to such a system can look further into it. After all, if you do not have SA_RESTART, you might not even have EINTR in the first place. > One caveat is that we do not know if their system headers hide the > real implementation of open(2) behind a C preprocessor macro, in > whcih case OPEN_RETURNS_EINTR wrapper may not work correctly. Yeah. I didn't think about that when I did the original "just do it everywhere" patch. But that is exactly what caused the problem on Windows (not a system macro, but in fact our own!). So I'm glad to have backed it off to a Makefile knob. -Peff